Repository navigation
Internal error in http2 with checkServerIdentity undefined #49839
Description
Activity
Try doing this:
`const options = {
settings: {
enableConnectProtocol: true
},
localPort: this.localPort
};if (checkServerIdentity) {
options.checkServerIdentity = checkServerIdentity;
}this.clientInt = connect('https://' + this.hostname + ':' + this.port, options);
`Thanks, of course, I did something like this. But as I wrote, I just filed the issue, as node.js asked me too. ("Please open an issue with this stack trace at") I assume, that the intention is, that it is either correctly handled or an meaningful error is thrown.
- added a commit that references this issue
on Sep 27, 2023 @martenrichter Thank you for your report. As you mentioned, need to throw
ERR_INVALID_ARG_TYPEinstead ofERR_INTERNAL_ASSERTIONfor this case. I created PR(#49896).- added a commit that references this issue
on Sep 30, 2023 - added a commit that references this issue
on Apr 15, 2024
Version
v18.18.0
Platform
Linux 3eaa088c9827 5.15.90.1-microsoft-standard-WSL2 #1 SMP Fri Jan 27 02:56:13 UTC 2023 x86_64 GNU/Linux
Subsystem
http2
What steps will reproduce the bug?
It happened with:
Important is that checkServerIdentity is undefined.
It says then:
and I am just filling it, since node.js asked me to.
I assume it can be easily worked around by not having checkServerIdentity in the object, when not used.
How often does it reproduce? Is there a required condition?
Always.
What is the expected behavior? Why is that the expected behavior?
Ignore the setting
What do you see instead?
The trace above.
Additional information
No response