Ada's license

@anonrig

Ada had 2 license files - LICENSE-APACHE and LICENSE-MIT from the initial commit but when Ada was added to Node.js in #46410, only the MIT license of Ada was added to the Node.js' LICENSE file. Is this intentional or should we also add Ada's Apache license to the Node.js license?

Also, the license section on Ada's readme, which was added in ada-url/ada#328, says:

License

This code is made available under the Apache License 2.0 as well as the MIT license. For unicode processing, we rely on a few functions from UniLib which are licensed under the Mozilla Public License v.2.0.

Our tests include third-party code and data. The benchmarking code includes third-party code: it is provided for research purposes only and not part of the library.

So should we also include a copy of Mozilla Public License Version 2.0?

cc @anonrig @lemire

If something is dual-licensed (or triple-licensed), you can pick the license you want - in our case MIT.

It couldn't be any other way because the MPL is a no-go for a MIT-licensed project like Node.js.

@bnoordhuis

@bnoordhuis a small portion of ada/idna uses mozilla licensed code. should we focus on replacing it with a mit-based solution?

a small portion of ada/idna uses mozilla licensed code

Does that code exist in this repository? Adding code to deps/ada that is not covered by deps/ada/LICENSE-MIT is problematic (or, as Ben said, a no-go).

The ada README can be useful...

https://github.com/ada-url/ada#license

https://github.com/ada-url/ada/blob/4215aed05d6b98fbab7ab310f62d16ff90380924/src/ada_idna.cpp#L2734

It is not hard for us to eliminate the UniLib code, it was integrated to save time but could be rewritten from scratch easily.

Does that code exist in this repository?

Yes, it's present in deps/ada:

node/deps/ada/ada.cpp

Lines 2853 to 2863 in 6fb10ca

    
           // This file is part of UniLib <http://github.com/ufal/unilib/>. 
        
           // 
        
           // Copyright 2014 Institute of Formal and Applied Linguistics, Faculty of 
        
           // Mathematics and Physics, Charles University in Prague, Czech Republic. 
        
           // 
        
           // This Source Code Form is subject to the terms of the Mozilla Public 
        
           // License, v. 2.0. If a copy of the MPL was not distributed with this 
        
           // file, You can obtain one at http://mozilla.org/MPL/2.0/. 
        
           // 
        
           // UniLib version: 3.3.1-dev 
        
           // Unicode version: 15.0.0

@lemire

@lemire removed UniLib code from Ada. we'll soon release v2.4.0. ada-url/idna#28

Navigation Menu

Repository navigation

Ada's license #47894

License

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// This file is part of UniLib <http://github.com/ufal/unilib/>.
	//
	// Copyright 2014 Institute of Formal and Applied Linguistics, Faculty of
	// Mathematics and Physics, Charles University in Prague, Czech Republic.
	//
	// This Source Code Form is subject to the terms of the Mozilla Public
	// License, v. 2.0. If a copy of the MPL was not distributed with this
	// file, You can obtain one at http://mozilla.org/MPL/2.0/.
	//
	// UniLib version: 3.3.1-dev
	// Unicode version: 15.0.0

Ada's license #47894

Description

License

Activity

bnoordhuis commented on May 6, 2023

anonrig commented on May 6, 2023

tniessen commented on May 6, 2023

lemire commented on May 6, 2023

RaisinTen commented on May 7, 2023

anonrig commented on May 7, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions