Sitelet https://github.com/nodejs/node/issues/47311

Repository navigation

`std::shared_ptr<T>::unique` was removed in C++20 #47311

Closed

Labels

opened

on Mar 30, 2023

Code:

node/src/node_threadsafe_cow-inl.h

Line 10 in 67660e8

if (!data_.unique()) {

Found in: #45427 (comment)

Refs: https://en.cppreference.com/w/cpp/memory/shared_ptr/unique

@nodejs/cpp-reviewers

targos
added
c++Issues and PRs that require attention from people who are familiar with C++.
on Mar 30, 2023
gengjiawen commented on Mar 30, 2023
gengjiawen
on Mar 30, 2023 · Hidden as outdated
RaisinTen commented on Mar 30, 2023
RaisinTen
on Mar 30, 2023
Member
I think #47315 might fix this.
Reacted by Jiawen Geng
RaisinTen
added a commit that references this issue on Mar 30, 2023
src: remove usage of `std::shared_ptr<T>::unique()`
409158a
gengjiawen commented on Mar 31, 2023
gengjiawen
on Mar 31, 2023
Member
I tested #47315 on VS2022, it works.
Reacted by Darshan Sen and Michaël Zasso
RaisinTen
closed this as completedin 1ff9824 on Apr 5, 2023
danielleadams
added a commit that references this issue on Jul 6, 2023
src: remove usage of `std::shared_ptr<T>::unique()`
f7b6e5b
MoLow
added a commit that references this issue on Jul 6, 2023
src: remove usage of `std::shared_ptr<T>::unique()`
ded4a5e
MayaLekova
added a commit that references this issue on May 22, 2026
src: remove usage of `std::shared_ptr<T>::unique()`
1ff9824

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests