Repository navigation
Remove snapshot.blob from 18.x branch #46133
Description
Activity
@danielleadams It looks like this was done when backporting 15f1051 on the v18.x branch in 2c0f7d4. It looks like something went wrong with the backport as the
snapshot.blobwas not there in the original commit.I suppose it should go into .gitignore
Do you want to send a PR?
Not really, other fish to fry
This is my first contribution to open source, i would love to work on this if this is something a beginner can do.
Thanks- This is my first contribution to open source, i would love to work on this if this is something a beginner can do.Sure go ahead, and let us know if you get stuck!
Alright sir.
Due to inactivity I'll proceed to fix this
- added a commit that references this issue
on Feb 12, 2023 - added a commit that references this issue
on Feb 18, 2023
Version
18.13.0
Platform
No response
Subsystem
No response
What steps will reproduce the bug?
No response
How often does it reproduce? Is there a required condition?
No response
What is the expected behavior?
Build artifacts shouldn't be in git repository, nor in the release tarball.
What do you see instead?
./snapshot.blob is in the git repository (branch 18.x) and in the release tarball of nodejs 18.13.0
Additional information
No response