Sitelet https://github.com/nodejs/node/issues/45598
Skip to content

Incorrect time zone offset for Pacific/Fiji #45598

Closed
Closed
Incorrect time zone offset for Pacific/Fiji#45598

Description

@felamaslen
felamaslen
opened on Nov 23, 2022

Version

v16.13.2 (also applies in v19.1.0)

Platform

Linux myhostname 6.0.8-arch1-1 #1 SMP PREEMPT_DYNAMIC Thu, 10 Nov 2022 21:14:24 +0000 x86_64 GNU/Linux

Subsystem

Intl API / ICU

What steps will reproduce the bug?

console.log(Intl.DateTimeFormat('en', { hour: 'numeric', minute: 'numeric', timeZone: 'Pacific/Fiji', timeZoneName: 'long' }).format(new Date('2022-11-18T00:00:00Z')))

How often does it reproduce? Is there a required condition?

100% of the time.

What is the expected behavior?

Outputs 12:00 PM Fiji Standard Time

What do you see instead?

Outputs 1:00 PM Fiji Summer Time

Additional information

Fiji cancelled DST in 2022: https://www.timeanddate.com/news/time/fiji-no-dst-2022-2023.html

Node.JS still thinks that Fiji uses DST in 2022.

Activity

  1. felamaslen commented on Nov 23, 2022

    @felamaslen
    felamaslen
    on Nov 23, 2022
    Author

    My system's time and date works fine:

    $ TZ=Pacific/Fiji date
Thu 24 Nov 00:11:55 +12 2022

  2. mscdex commented on Nov 23, 2022

    @mscdex
    mscdex
    on Nov 23, 2022
    Contributor

    This was already fixed with the ICU timezone data update 2022f here, which was only merged 7 days ago, so it hasn't had a chance to make its way into any releases yet.

  3. bnoordhuis
    closed this as completedon Dec 4, 2022

  4. felamaslen commented on Dec 6, 2022

    @felamaslen
    felamaslen
    on Dec 6, 2022
    Author

    I can still reproduce this issue in v16.18.1 and v18.12.1. The only release I can see that it has been fixed on is v19.2.0.

  5. mscdex commented on Dec 6, 2022

    @mscdex
    mscdex
    on Dec 6, 2022
    Contributor

    Right, it has to be backported to those branches first, like most other (non-semver major) commits. As of this moment, backported commits have only landed for v14.x. See also the v16.x backport (which will be the basis for the v18.x backport apparently).

  6. richardlau commented on Dec 6, 2022

    @richardlau
    richardlau
    on Dec 6, 2022
    Member

    v18.x-staging landed the ICU update so the timezone update from main has been cherry-picked onto it.
    I've volunteered to do the next 14 and 16 releases -- current plan (nodejs/Release#658, nodejs/Release#567) is targetting next week.

    If you need the updated timezone information before the Node.js releases are ready, I documented a workaround in nodejs/Release#773 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions