Sitelet https://github.com/nodejs/node/issues/44865
Skip to content

Timezone update workflow/tool doesn't work? #44865

Description

@richardlau

ICU updated to tzdata 2022d recently unicode-org/icu-data#30.
https://github.com/nodejs/node/actions/runs/3166758920 should have picked this up and opened a PR but it doesn't appear to have done.

Activity

  1. RaisinTen commented on Oct 2, 2022

    @RaisinTen
    Member

    Happens because

    spawnSync(
    'icupkg', [
    '-a',
    file,
    'icudt*.dat',
    ], { cwd: 'deps/icu-small/source/data/in/' }
    );
    uses globbing, so the command silently fails with a icupkg: unable to open input file "icudt*.dat" error which shows up when you inspect the stderr property on the returned object stderr. Replacing with execSync works (I've tested on my fork, see https://github.com/RaisinTen/node/actions/runs/3171963122/jobs/5165930627 and RaisinTen#2).

  2. RaisinTen commented on Oct 3, 2022

    @RaisinTen
    Member

    PR - #44870

  3. added a commit that references this issue on Oct 3, 2022
  4. added a commit that references this issue on May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions