Repository navigation
No error is emitted on response destroy when socket is already destroyed #35923
Description
Activity
- changed the title
[-]No error is emitted on response when socket is destroyed[/-][+]No error is emitted on response destroy when socket is already destroyed[/+]on Nov 2, 2020 - added a commit that references this issue
on Mar 22, 2023 - added a commit that references this issue
on Jul 5, 2023 - added a commit that references this issue
on Sep 5, 2023 - added 2 commits that reference this issue
on Oct 7, 2023 const http = require('http'); const request = http.get('http://httpbin.org/anything', response => { setTimeout(() => { console.log(`request.destroyed = ${request.destroyed}`); console.log(`response.destroyed = ${response.destroyed}`); response.destroy(new Error('failure')); }, 1000); });
request.destroyed = false response.destroyed = false node:events:498 throw er; // Unhandled 'error' event ^ Error: failure at Timeout._onTimeout (/XXX/repro.js:8:26) at listOnTimeout (node:internal/timers:581:17) at process.processTimers (node:internal/timers:519:7) Emitted 'error' event on ClientRequest instance at: at Socket.socketErrorListener (node:_http_client:502:9) at Socket.emit (node:events:532:35) at emitErrorNT (node:internal/streams/destroy:170:8) at emitErrorCloseNT (node:internal/streams/destroy:129:3) at process.processTicksAndRejections (node:internal/process/task_queues:82:21) Node.js v22.4.1AFAICT,this is no longer reproducible. If you disagree, feel free to re-open.
Linux solus 5.6.19-159.current #1 SMP PREEMPT Fri Oct 16 17:49:06 UTC 2020 x86_64 GNU/LinuxWhat steps will reproduce the bug?
How often does it reproduce? Is there a required condition?
Always.
What is the expected behavior?
An error with a message
failure.What do you see instead?
No error.
Additional information
While I understand that
requestis destroyed on socket close, theresponse.destroylogic is broken:node/lib/_http_incoming.js
Lines 121 to 125 in c1da528
The error is not thrown because the socket has been destroyed. Although the response has not.