Repository navigation
Fix Node.js' code coverage/code coverage job #35646
Description
Activity
- changed the title
[-]Fixe Node.js' code coverage/code coverage job[/-][+]Fix Node.js' code coverage/code coverage job[/+]on Oct 14, 2020 Have we ever tried adding c8 to https://github.com/nodejs/citgm/ ? (I searched for it and I don't think so?)
Reacted by Daijiro Wachiwe should add it, it isn't included right now afaik. For reference this is the lookup table
Have we ever tried adding c8 to https://github.com/nodejs/citgm/ ? (I searched for it and I don't think so?)
@joyeecheung @MylesBorins not a bad idea, but it wouldn't have actually caught this, because it only breaks on Node.js' own coverage -- which now has different file paths (c8 would continue working for userland.)
Reacted by Daijiro Wachi- added a commit that references this issue
on Oct 22, 2020 - added 2 commits that reference this issue
on Dec 8, 2020
The problem(s)
1. new file paths are breaking the coverage reporting
File paths for Node.js' own files now have this form
node:/internal/cluster/shared_handle:node:prefix..jsprefix.I will happily fix this problem in the test reporter, but could someone point me towards where these changes were made (@watilde, @guybedford?) -- I want to make sure I link to the change in the reporter codebase.
2. nightly coverage is broken again
Coverage has been broken for several nights in a row. I believe this is due to an unrelated CI/CD upgrade?
Suggested fix
CC: @nodejs/testing