Repository navigation
馃殌 AbortController in Node task list聽#33528
Description
Activity
Starting to work on an Initial list of core APIs that can utilize AbortController. Please feel free to edit this everyone.
@jasnell hey just to understand, are you interested in only supporting the promise (or promisifed) versions of the APIs (at least initially) or would you like to also explore adding it to the callback versions?
(Inb4: doing one or the other does not preclude us from doing one or the other in the future)
Supporting on callback versions is certainly possible and would likely help make things more consistent.
Reacted by Benjamin Gruenbaum and Philip ChimentoWe need to also think about abort detection,
In the browserfetchthere's very vague AbortError which is DOMException with name="AbortError",
And the protocol is kindaerror instanceof Error && error.name === "AbortError"
There is no direct constructor for that error
Minimal code to get it:c = new AbortController() p = fetch('', {signal: c.signal}).catch(e => e) c.abort() abortError = await p; console.log(abortError, abortError.name, abortError.message)@Bnaya thanks, I added it to the list, feel free to spin up a document and bikeshed there - it's not like it's half of what we do together in our 9-5 anyway :D
@ptomato would either of you be interested in taking the API bikeshedding part?
I went over some APIs? (I'm trying to figure for what APIs it makes sense but probably not how it would look like). Error are also interesting to discuss
@ptomato would either of you be interested in taking the API bikeshedding part?
Yes, definitely. I had actually already started on that for myself. There is some proof of concept in https://github.com/ptomato/node/commits/31971-abortcontroller . I don't have much time to work on it this week, but next week I can continue.
Reacted by Benjamin GruenbaumThis has been superseded and stalled so I'm closing. The usual "if anyone feels strongly - feel free to reopen" :)
Hey,
James started a PR at #33527 and we're having a summit meeting in openjs-foundation/summit#273 regarding adding AbortController to core.
Other than checking out the code and testing it (please do) James listed some work items in that PR when I asked and I figured it would be nice to have a list of them here.
This list is mutable. While our process is typically that collaborators don't edit each other's posts - you are welcome to add/remove/edit this list (please do!) as you see fit:
AbortControllerand see where it makes sense.fs.promise.readFilewhich is multiple operations (we can cancel in between) but anfs.promises.readis not discreetly cancellable.util.promisifyshould support cancellation, and if it does what that API should look like.AbortErrors when things go wrong.