Sitelet https://github.com/nodejs/node/issues/2942
Skip to content

Cannot override arm_fpu config #2942

Closed
Closed
Cannot override arm_fpu config#2942
Labels
armIssues and PRs related to the ARM architecture.buildIssues and PRs related to Node.js builds or CI infrastructure.

Description

@kapouer
kapouer
opened on Sep 18, 2015

Hi,
When building nodejs for debian armel, one must set arm_fpu to "vfp".
Alas, -Darm_fpu=fvp is overriden by https://github.com/nodejs/node/blob/master/configure#L613.
Is it possible to check if arm_fpu is set in configure before setting it ?

Activity

  1. kapouer commented on Sep 18, 2015

    @kapouer
    kapouer
    on Sep 18, 2015
    ContributorAuthor

    Forgot basic information like nodejs version 4.0.0

  2. brendanashworth
    added
    questionIssues asking questions about Node.js.
    armIssues and PRs related to the ARM architecture.
    on Sep 18, 2015

  3. bnoordhuis commented on Sep 18, 2015

    @bnoordhuis
    bnoordhuis
    on Sep 18, 2015
    Member

    It would need a new configure flag but that's pretty straightforward, you can use the logic for --with-mips-fpu-mode as a template.

  4. bnoordhuis
    added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    and removed
    questionIssues asking questions about Node.js.
    on Sep 18, 2015

  5. kapouer commented on Sep 18, 2015

    @kapouer
    kapouer
    on Sep 18, 2015
    ContributorAuthor

    Here's what i meant, but i'm not sure it works.

  6. bnoordhuis commented on Sep 18, 2015

    @bnoordhuis
    bnoordhuis
    on Sep 18, 2015
    Member

    I don't think that works, assuming -Darm_fpu=fvp is what needs to be passed to gyp. The configure script runs before gyp's configure step; no variables have been set at that point yet.

  7. kapouer commented on Sep 18, 2015

    @kapouer
    kapouer
    on Sep 18, 2015
    ContributorAuthor

    Oh, got it.

  8. kapouer commented on Sep 18, 2015

    @kapouer
    kapouer
    on Sep 18, 2015
    ContributorAuthor

    This is better, i'll test it a little and submit a PR !

  9. bnoordhuis
    closed this as completedin 17665afon Oct 7, 2015
  10. jasnell
    added a commit that references this issue on Oct 8, 2015

    build: add --with-arm-fpu option

    b3c5ad1
  11. sjarmak
    added a commit that references this issue on Jul 27, 2026

    build: add --with-arm-fpu option

    17665af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    armIssues and PRs related to the ARM architecture.buildIssues and PRs related to Node.js builds or CI infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions