Missing assert from merge #2780

Activity

1. mscdex

   added

   c++Issues and PRs that require attention from people who are familiar with C++.Issues and PRs that require attention from people who are familiar with C++.

   on Sep 9, 2015
2. bmeck commented on Sep 9, 2015

   

   bmeck

   on Sep 9, 2015

   Member

   More actions

   This was discovered as we were checking addon compatibility and saw a segfault from trying to load a 0.12.7 version of fsevents against 4.0.0. The segfault occurs prior to the version mismatch message.
3. cjihrig commented on Nov 16, 2015

   

   cjihrig

   on Nov 16, 2015

   Contributor

   More actions

   Is this still an issue? I tested with v4.0.0 and got the described segfault:

   Segmentation fault: 11

   However, I ran with master and got:

   module.js:448
     return process.dlopen(module, path._makeLong(filename));
                    ^
   
   Error: Module version mismatch. Expected 47, got 14.
       at Error (native)
       at Object.Module._extensions..node (module.js:448:18)
       at Module.load (module.js:354:32)
       at Function.Module._load (module.js:311:12)
       at Module.require (module.js:364:17)
       at require (module.js:383:17)
       at Object.<anonymous> (/private/tmp/foo.js:2:16)
       at Module._compile (module.js:423:26)
       at Object.Module._extensions..js (module.js:430:10)
       at Module.load (module.js:354:32)
   
4. jasnell commented on Nov 16, 2015

   

   jasnell

   on Nov 16, 2015

   Member

   More actions

   @cjihrig ... can you check 4.2.2?
5. cjihrig commented on Nov 16, 2015

   

   cjihrig

   on Nov 16, 2015

   Contributor

   More actions

   With v4.2.2:

   module.js:460
     return process.dlopen(module, path._makeLong(filename));
                    ^
   
   Error: Module version mismatch. Expected 46, got 14.
       at Error (native)
       at Object.Module._extensions..node (module.js:460:18)
       at Module.load (module.js:356:32)
       at Function.Module._load (module.js:311:12)
       at Module.require (module.js:366:17)
       at require (module.js:385:17)
       at Object.<anonymous> (/private/tmp/foo.js:2:16)
       at Module._compile (module.js:435:26)
       at Object.Module._extensions..js (module.js:442:10)
       at Module.load (module.js:356:32)
   
6. jasnell commented on Nov 16, 2015

   

   jasnell

   on Nov 16, 2015

   Member

   More actions

   So long as that's the expected error, if it's working in v4.2.x and master, I'd say it's resolved.
7. cjihrig commented on Nov 16, 2015

   

   cjihrig

   on Nov 16, 2015

   Contributor

   More actions

   Seems as good as can be expected, and much better than a segfault. But I'll wait to hear from @julianduque or @bmeck
8. cjihrig commented on Nov 18, 2015

   

   cjihrig

   on Nov 18, 2015

   Contributor

   More actions

   Haven't heard anything, and the situation seems to have improved. Closing.
9. cjihrig

   closed this as completedon Nov 18, 2015