Sitelet https://github.com/nodejs/node/issues/2617
Skip to content

.exe builds not manifested #2617

Closed
Closed
.exe builds not manifested#2617
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.windowsIssues and PRs related to the Windows platform.

Description

@silverwind
silverwind
opened on Aug 30, 2015

The .exe builds at https://iojs.org/download/release/latest/win-x86/ seem to not be manifested and in turn do not benefit from #2332. On Window 10, os.release() reports 6.2.9200 which is the default for unmanifested builds. The binaries provided by installer are reporting the correct version 10.0.10240.

cc: @orangemocha

Activity

  1. silverwind
    added
    windowsIssues and PRs related to the Windows platform.
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    on Aug 30, 2015

  2. silverwind commented on Aug 30, 2015

    @silverwind
    silverwind
    on Aug 30, 2015
    ContributorAuthor

    Wild guess, but could it be because the msbuild task (which presumably builds the exe files) is missing a few switches compared to the msibuild?

  3. silverwind
    changed the title [-].exe builds no manifested for Windows 10[/-] [+].exe builds not manifested[/+] on Aug 30, 2015

  4. orangemocha commented on Aug 31, 2015

    @orangemocha
    orangemocha
    on Aug 31, 2015
    Contributor

    cc @joaocgreis , who I know was working on a fix.

  5. joaocgreis commented on Sep 11, 2015

    @joaocgreis
    joaocgreis
    on Sep 11, 2015
    Member

    @silverwind for version 3.0.0 it is indeed broken, but for 3.1.0 onwards it works. Can you confirm if this is working for new versions for you?

  6. silverwind commented on Sep 11, 2015

    @silverwind
    silverwind
    on Sep 11, 2015
    ContributorAuthor

    Yeah, looks to be working indeed, sorry about that.

    screen shot 2015-09-11 at 8 02 36 pm

  7. silverwind
    closed this as completedon Sep 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions