Repository navigation
[Converge] child_process argument type checking #2515
Description
Activity
Correct, AFAIK this has not yet been completed. It's actually on my list for later this week but if someone gets to it before then ..... ;-)
@sam-github @trevnorris ... this particular set of commits were yours originally, I believe. Would either of you be able to take a look to see what needs to land in nodejs/node?
lint fix doesn't matter. processing the arguments the same would be helpful, but not sure if it's currently done that way ATM. so may be worth bringing in.
@trevnorris I'm assigning this to you, please close this when it lands, before the end of the week please.
@rvagg want me to just cherry-pick the applicable onto master?
@trevnorris your call, including assessing whether this is even necessary, PR obviously even if cherry-picking.
ping @trevnorris, are we close here?
@rvagg @trevnorris ... I'm going to take a look at this today. I'll port over the changes and open a new PR against master
- added 2 commits that reference this issue
on Sep 3, 2015 - added a commit that references this issue
on Sep 3, 2015
Continuing from nodejs/node-convergence-archive#22, I don't believe this has been done yet, @jasnell can you confirm please? That thread seems to have enough agreement to pull these changes in. Marking on the 4.0.0 milestone.