Sitelet https://github.com/nodejs/node/issues/1972
Skip to content

Reorder authors in README.md #1972

Description

@jbergstroem

(brought up in #1966, moved to its own place)

@rvagg suggested that we should reorder authors to remove any significance to their wg membership, such as when they joined or if they are part of the TC.

Lets agree on how this should be ordered. So far, last name or github username seems to be the two options. I like the idea of using the github username (and subsequently moving that ahead of name/email).

Activity

  1. added
    docIssues and PRs related to Node.js documentation.
    on Jun 14, 2015
  2. mscdex commented on Jun 14, 2015

    @mscdex
    Contributor

    Anything that makes it easier to simply copy and paste for Reviewed-By: lines 😀

  3. jbergstroem commented on Jun 14, 2015

    @jbergstroem
    MemberAuthor

    @mscdex that's already solved by #1966 👍

  4. silverwind commented on Jun 14, 2015

    @silverwind
    Contributor

    @mscdex

    function revline() {
      git log | grep -i --color=never reviewed.+$1 | head -1 | xargs | tee >(pbcopy)
    }

    Needs a second terminal, but I'm sure there's a way to integrate this into vim too.

  5. mscdex commented on Jun 14, 2015

    @mscdex
    Contributor

    @silverwind It's actually usually easier/faster for me to grab it from the readme. I'm not always at a machine with git and such installed.

  6. silverwind commented on Jun 14, 2015

    @silverwind
    Contributor

    How about this format? (Would have put the real name in parens, but that would kill copiability)

    @mscdex how do you merge witout git installed? 😯

  7. mscdex commented on Jun 14, 2015

    @mscdex
    Contributor

    @silverwind I suppose that format is ok.

  8. jbergstroem commented on Jun 14, 2015

    @jbergstroem
    MemberAuthor

    I'm ok with that too.

  9. silverwind commented on Jun 14, 2015

    @silverwind
    Contributor

    And of course, sort by username.

  10. chrisdickinson commented on Jun 15, 2015

    @chrisdickinson
    Contributor

    I am only sort of kidding here, but maybe we should sort by sha1 hash of collaborator line? I'd like to encourage folks to spell their names using whatever orthography they would naturally use, and sha1 gets us away from having to figure out how to sort multiple orthographies.

    Edit: as @silverwind suggests, sorting by username would also work and involve far less hashing :)

    Needs a second terminal, but I'm sure there's a way to integrate this into vim too.

    You should be able to just do :!revline (I think.) If not, turning it into a tiny shell script on $PATH would work.

  11. piscisaureus commented on Jun 15, 2015

    @piscisaureus
    Contributor

    @rvagg suggested that we should reorder authors to remove any significance to their wg membership, such as when they joined or if they are part of the TC.

    Was any motivation given?

  12. jbergstroem commented on Jun 15, 2015

    @jbergstroem
    MemberAuthor

    @piscisaureus here's the full quote from the PR:

    I've been thinking that maybe putting them in full alphabetical order would be best, TC members included, it decreases the importance of the TC slightly which I think is appropriate for how this project actually works.

    Thoughts anyone?

  13. trevnorris commented on Jun 16, 2015

    @trevnorris
    Contributor

    Don't fully agree with that sentiment. While all collaborators are equals in terms of signing off a PR, the TSC is the team that has the absolute final say when something is controversial. So I believe that list of names should be at the top, not to show superiority but instead to make it easier for anyone to find their information.

  14. brendanashworth commented on Jun 24, 2015

    @brendanashworth
    Contributor

    Counter-suggestion: two groups of alphabetically sorted collaborators, those behind the security@ email, then those who aren't. (catering to both users searching for a contact & collaborators looking for reviewed-by emails)

  15. jbergstroem commented on Jun 24, 2015

    @jbergstroem
    MemberAuthor

    @brendanashworth isn't all security email supposed to land in security@ anyway? (point being, we don't want people to be confused about where to send security related stuff)

  16. brendanashworth commented on Jun 25, 2015

    @brendanashworth
    Contributor

    @jbergstroem it should, but if someone is confused they may look down to the collaborator list and pick the first one they see. Probably not, but its just an idea.

  17. jbergstroem commented on Sep 3, 2015

    @jbergstroem
    MemberAuthor

    Landed with #2322 (6ce8f5f)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docIssues and PRs related to Node.js documentation.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions