Sitelet https://github.com/nodejs/node/issues/1850
Skip to content

npm: SSL error on v2.2.0 #1850

Closed
Closed
npm: SSL error on v2.2.0#1850
Labels
confirmed-bugIssues and PRs for confirmed bugs.httpIssues and PRs related to the http subsystem.npmIssues and PRs related to the npm client dependency or the npm registry.

Description

@targos
targos
opened on May 31, 2015

Attempting to install a module with npm fails with the following error:
SSL Error: https://registry.npmjs.org/test does not support SSL.

Reproduced on Windows 8.1 x64 and Windows 10 x64.

The error only happens for modules that were never installed on the machine. My guess is that npm uses the local cache for known modules.

C:\Users\Michael\test>iojs -v
v2.2.0

C:\Users\Michael\test>npm -v
2.11.0

C:\Users\Michael\test>npm install abc
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\\Program Files\\iojs\\node.exe" "C:\\Program Files\\iojs\\node
_modules\\npm\\bin\\npm-cli.js" "install" "abc"
npm ERR! node v2.2.0
npm ERR! npm  v2.11.0
npm ERR! code ESSL

npm ERR! SSL Error: https://registry.npmjs.org/abc does not support SSL
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\Michael\test\npm-debug.log

C:\Users\Michael\test2>iojs -v
v2.1.0

C:\Users\Michael\test2>npm -v
2.10.1

C:\Users\Michael\test2>npm install abc
abc@0.6.1 node_modules\abc

Activity

  1. targos commented on May 31, 2015

    @targos
    targos
    on May 31, 2015
    MemberAuthor

    Error is generated by the request module, here: https://github.com/request/request/blob/04bcd915dff978bd4874faafdf5567abe9230636/request.js#L1067

  2. campersau commented on May 31, 2015

    @campersau
    campersau
    on May 31, 2015

    +1 this also breaks my io.js tests on travis https://travis-ci.org/FredrikNoren/ungit/jobs/64777573

  3. rvagg commented on May 31, 2015

    @rvagg
    rvagg
    on May 31, 2015
    Member

    this seems to be impacting Linux as well, OSX appears to be fine

    ping @othiym23, @iama

  4. targos commented on May 31, 2015

    @targos
    targos
    on May 31, 2015
    MemberAuthor

    1eec5f0

  5. targos commented on May 31, 2015

    @targos
    targos
    on May 31, 2015
    MemberAuthor

    this broke the response.hasOwnProperty('client') check from request

  6. rvagg commented on May 31, 2015

    @rvagg
    rvagg
    on May 31, 2015
    Member

    reversion @ #1851, see comments there, sorry for pulling you in @othiym23 & @iama (I meant that to be @-iarna, so sorry whoever you are).

  7. targos commented on May 31, 2015

    @targos
    targos
    on May 31, 2015
    MemberAuthor

    there was no CI run for #1829 :(

  8. rvagg commented on May 31, 2015

    @rvagg
    rvagg
    on May 31, 2015
    Member

    probably wouldn't have helped, we're still shaving the test-npm yak, /cc @fishrosk123

  9. targos commented on May 31, 2015

    @targos
    targos
    on May 31, 2015
    MemberAuthor

    /cc @Fishrock123

  10. targos
    changed the title [-]npm (v2.2.0): SSL error on Windows[/-] [+]npm: SSL error on v2.2.0[/+] on May 31, 2015

  11. vitaly-t commented on May 31, 2015

    @vitaly-t
    vitaly-t
    on May 31, 2015
    Contributor

    +1, broke my IO.js tests on Travis CI.

  12. wzrdtales commented on May 31, 2015

    @wzrdtales
    wzrdtales
    on May 31, 2015

    +1, my tests on travis with io.js are also broken

  13. jakubpawlowicz
    added a commit that references this issue on May 31, 2015

    Pins iojs on Travis to 2.1.0.

    a90b572

  14. Globegitter commented on May 31, 2015

    @Globegitter
    Globegitter
    on May 31, 2015

    @rvagg Just installed iojs 2.2.0 on mac osx and the same bug is affecting me.

  15. seemsindie commented on May 31, 2015

    @seemsindie
    seemsindie
    on May 31, 2015

    +1 Same error here on arch linux

  16. 20 remaining items

  17. silverwind
    added
    httpIssues and PRs related to the http subsystem.
    and removed
    tlsIssues and PRs related to the tls subsystem.
    on May 31, 2015
  18. wolfie
    added a commit that references this issue on May 31, 2015

    disabling testing on iojs 2.2.0

    8c732ad
  19. silverwind
    added a commit that references this issue on May 31, 2015

    http: revert deprecation of client property

    4d6b768

  20. silverwind commented on May 31, 2015

    @silverwind
    silverwind
    on May 31, 2015
    Contributor

    Fix has landed in 4d6b768. Let's hope one of the release guys is up for a quick patch release.

    cc: @Fishrock123 @rvagg @chrisdickinson

  21. chrisdickinson commented on Jun 1, 2015

    @chrisdickinson
    chrisdickinson
    on Jun 1, 2015
    Contributor

    Request's response.hasOwnProperty('client') check does not see it because it is a getter/setter.

    A {g,s}etter would have been okay – the problem is that the property was set on the prototype instead of the instance.

  22. Fishrock123 commented on Jun 1, 2015

    @Fishrock123
    Fishrock123
    on Jun 1, 2015
    Contributor

    A {g,s}etter would have been okay – the problem is that the property was set on the prototype instead of the instance.

    Yes, I think we should do a static analysis and reconsider deprecating in the future.

  23. dougwilson commented on Jun 1, 2015

    @dougwilson
    dougwilson
    on Jun 1, 2015
    Member

    It's amusing to see so many people's tests failing on Travis CI because of this issue, mainly because many, many module are only specifying iojs for nvm to install, which is simply asking for a lot of pain.

  24. capaj commented on Jun 1, 2015

    @capaj
    capaj
    on Jun 1, 2015

    @dougwilson still lesser pain than to update travis.yml manually with each new io.js release. I for one will not bother to specify an io.js version in my travis.yml, because I think that this situation will not repeat again.

  25. silverwind commented on Jun 1, 2015

    @silverwind
    silverwind
    on Jun 1, 2015
    Contributor

    2.2.1 is out, fixing this. Get it while it's hot!

  26. silverwind
    closed this as completedon Jun 1, 2015

  27. sbrl commented on Jun 3, 2015

    @sbrl
    sbrl
    on Jun 3, 2015

    How can I update npm if when I run npm update npm -g --force it fails because of this bug?

  28. ljharb commented on Jun 3, 2015

    @ljharb
    ljharb
    on Jun 3, 2015
    SponsorMember

    @sbrl you need to update io.js itself to v2.2.1 - you can't fix it with npm. also npm install -g npm@latest to update npm.

  29. sbrl commented on Jun 3, 2015

    @sbrl
    sbrl
    on Jun 3, 2015

    @ljharb Thanks, that fixed it :)

  30. andrewdeandrade
    added a commit that references this issue on Jun 3, 2015

    http: revert deprecation of client property

    9176305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    confirmed-bugIssues and PRs for confirmed bugs.httpIssues and PRs related to the http subsystem.npmIssues and PRs related to the npm client dependency or the npm registry.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions