Sitelet https://github.com/nodejs/node/issues/1485
Skip to content

isNaN(Buffer.prototype) crashes #1485

Closed
Closed
isNaN(Buffer.prototype) crashes#1485
Labels
bufferIssues and PRs related to the buffer subsystem.confirmed-bugIssues and PRs for confirmed bugs.

Description

@tolmasky
tolmasky
opened on Apr 21, 2015

isNaN(Buffer.prototype)
Assertion failed: ((obj_data) != (nullptr)), function StringSlice, file ../src/node_buffer.cc, line 237.
Abort trap: 6

Activity

  1. monsanto commented on Apr 21, 2015

    @monsanto
    monsanto
    on Apr 21, 2015
    Contributor

    Reproduced, PR in one sec.

  2. mscdex
    added
    confirmed-bugIssues and PRs for confirmed bugs.
    bufferIssues and PRs related to the buffer subsystem.
    on Apr 21, 2015

  3. bnoordhuis commented on Apr 21, 2015

    @bnoordhuis
    bnoordhuis
    on Apr 21, 2015
    Member

    Even simpler test case: +Buffer.prototype. It's because of the custom .toString method on the prototype object...

  4. Fishrock123 commented on Apr 21, 2015

    @Fishrock123
    Fishrock123
    on Apr 21, 2015
    Contributor

    isNaN(Buffer.prototype)

    I am very curious as to how/why you ended up doing this though.

  5. brendanashworth
    added a commit that references this issue on Jun 9, 2015

    buffer: prevent failed assertions

    ca408dc
  6. trevnorris
    added a commit that references this issue on Jun 25, 2015

    buffer: prevent abort on bad proto

    1cd9eeb

  7. trevnorris commented on Jun 25, 2015

    @trevnorris
    trevnorris
    on Jun 25, 2015
    Contributor

    Fixed by 1cd9eeb.

  8. trevnorris
    closed this as completedon Jun 25, 2015
  9. mscdex
    added a commit that references this issue on Jul 9, 2015

    buffer: prevent abort on bad proto

    40c334d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bufferIssues and PRs related to the buffer subsystem.confirmed-bugIssues and PRs for confirmed bugs.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions