Sitelet https://github.com/nodejs/node/issues/1374
Skip to content

Fatal Error (Abort) creating string larger than 268435440 bytes #1374

Closed
Closed
Fatal Error (Abort) creating string larger than 268435440 bytes#1374
Labels
bufferIssues and PRs related to the buffer subsystem.v8 engineIssues and PRs related to the V8 dependency.
Milestone
4.0.0

Description

@juliangruber
juliangruber
opened on Apr 8, 2015

Given this script:

var kMaxLength = process.binding('smalloc').kMaxLength;
console.log(kMaxLength, 'kMaxLength');

var len = 268435440;
var blob = new Buffer(len).toString('utf8');
console.log(len, 'ok');

len = 268435441;
blob = new Buffer(len).toString('utf8');
console.log(len, 'ok');

The output should be:

1073741823 'kMaxLength'
268435440 'ok'
268435441 'ok'

But it actually is:

1073741823 'kMaxLength'
268435440 'ok'


#
# Fatal error in ../deps/v8/src/handles.h, line 48
# CHECK(location_ != NULL) failed
#

==== C stack trace ===============================

 1: ??
 2: ??
 3: ??
 4: ??
 5: ??
 6: ??
 7: ??
 8: ??
 9: ??
Illegal instruction: 4

Activity

  1. juliangruber commented on Apr 8, 2015

    @juliangruber
    juliangruber
    on Apr 8, 2015
    MemberAuthor

    this is ~256mb

  2. petkaantonov commented on Apr 8, 2015

    @petkaantonov
    petkaantonov
    on Apr 8, 2015
    Contributor

    @trevnorris @chrisdickinson and I are already working on this FWIW

  3. petkaantonov commented on Apr 8, 2015

    @petkaantonov
    petkaantonov
    on Apr 8, 2015
    Contributor

    If your file is just using ascii, you can work around this currently by specifying 'ascii' as encoding

  4. Fishrock123
    added
    smalloc
    bufferIssues and PRs related to the buffer subsystem.
    on Apr 8, 2015

  5. Fishrock123 commented on Apr 8, 2015

    @Fishrock123
    Fishrock123
    on Apr 8, 2015
    Contributor

    I feel like this has already been reported, but I can't find the issue..

  6. juliangruber commented on Apr 8, 2015

    @juliangruber
    juliangruber
    on Apr 8, 2015
    MemberAuthor

    here is a stacktrace i get on linux:

    ==== C stack trace ===============================

 1: V8_Fatal
 2: v8::String::NewFromUtf8(v8::Isolate*, char const*, v8::String::NewStringType, int)
 3: node::StringBytes::Encode(v8::Isolate*, char const*, unsigned long, node::encoding)
 4: node::Buffer::Utf8Slice(v8::FunctionCallbackInfo<v8::Value> const&)
 5: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&))
 6: ??
 7: ??
Illegal instruction (core dumped)
  7. juliangruber
    changed the title [-]Fatal Error creating buffer larger than 268435440 bytes[/-] [+]Fatal Error creating string larger than 268435440 bytes[/+] on Apr 8, 2015

  8. juliangruber commented on Apr 8, 2015

    @juliangruber
    juliangruber
    on Apr 8, 2015
    MemberAuthor

    updated the title, the issue is obviously the .toString()

  9. Fishrock123 commented on Apr 8, 2015

    @Fishrock123
    Fishrock123
    on Apr 8, 2015
    Contributor

    @juliangruber ah. Is this related to #649?

  10. Fishrock123
    added
    v8 engineIssues and PRs related to the V8 dependency.
    and removed
    smalloc
    on Apr 8, 2015

  11. petkaantonov commented on Apr 8, 2015

    @petkaantonov
    petkaantonov
    on Apr 8, 2015
    Contributor

    @Fishrock123 yes, there is even a same issue reported deep in the comments.

    It's not a v8 issue, while v8 does have a smallish limit for strings allocated in the js-heap (the 268mb or so), it is our fault for trying to allocate the string in js-heap in the first place.

  12. brendanashworth commented on Aug 14, 2015

    @brendanashworth
    brendanashworth
    on Aug 14, 2015
    Contributor

    This doesn't seem to be an issue with the new Buffer rewrite / removal of smalloc:

    brendanashworth in ~ $ node -v
v2.1.0
brendanashworth in ~ $ node test
1073741823 'kMaxLength'
268435440 'ok'
FATAL ERROR: invalid array length Allocation failed - process out of memory
Abort trap: 6
    brendanashworth in ~ $ node -v
v3.0.0
brendanashworth in ~ $ node test
268435440 'ok'
268435441 'ok'

    Closing this for now, feel free to reopen if I'm wrong! :)

  13. brendanashworth
    closed this as completedon Aug 14, 2015

  14. 5 remaining items

  15. trevnorris
    added
    land-on-4x
    on Sep 3, 2015
  16. trevnorris
    added this to the 4.0.0 milestone on Sep 3, 2015

  17. trevnorris commented on Sep 3, 2015

    @trevnorris
    trevnorris
    on Sep 3, 2015
    Contributor

    @rvagg Adding this to the v4.0.0 milestone because it's a patch that prevents a possible segfault.

  18. Fishrock123
    added 2 commits that reference this issue on Sep 3, 2015

    src: fix memory leak in ExternString

    d82f4d7

    src: fix memory leak in ExternString

    6353564

  19. mhart commented on Oct 4, 2015

    @mhart
    mhart
    on Oct 4, 2015
    Contributor

    I believe this should be reopened. Output under v4.1.1 is:

    268435440 'ok'
buffer.js:378
    throw new Error('toString failed');
    ^

Error: toString failed
    at Buffer.toString (buffer.js:378:11)
    at Object.<anonymous> (/Users/michael/github/rss/data/test.js:6:24)
    at Module._compile (module.js:434:26)
    at Object.Module._extensions..js (module.js:452:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:475:10)
    at startup (node.js:117:18)
    at node.js:951:3

  20. bnoordhuis commented on Oct 4, 2015

    @bnoordhuis
    bnoordhuis
    on Oct 4, 2015
    Member

    @mhart This issue is about node aborting on large strings. It no longer does, it throws a catchable exception.

  21. mhart commented on Oct 4, 2015

    @mhart
    mhart
    on Oct 4, 2015
    Contributor

    OK, I was going by the expected output in the issue description.

  22. Fishrock123
    changed the title [-]Fatal Error creating string larger than 268435440 bytes[/-] [+]Fatal Error (Abort) creating string larger than 268435440 bytes[/+] on Oct 4, 2015

  23. arjunkori commented on Oct 21, 2016

    @arjunkori
    arjunkori
    on Oct 21, 2016

    i am getting the same issue ,

      buffer.js:378
    throw new Error('toString failed');^
Error: toString failed
    at Buffer.toString (buffer.js:378:11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bufferIssues and PRs related to the buffer subsystem.v8 engineIssues and PRs related to the V8 dependency.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions