Sitelet https://github.com/nodejs/node/compare/b261178...f6940df
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b261178
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f6940df
Choose a head ref
  • 2 commits
  • 6 files changed
  • 1 contributor

Commits on May 4, 2016

  1. src: remove unused #include statement 

    strcasecmp() is not used in src/node_http_parser.cc so there is no need
to include its header file.

PR-URL: #6582
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis
    bnoordhuis committed May 4, 2016
    Configuration menu
    Copy the full SHA
    6db772d View commit details
    Browse the repository at this point in the history

  2. src: don't use locale-sensitive strcasecmp() 

    strcasecmp() is affected by the current locale as configured through
e.g. the LC_ALL environment variable and the setlocale() libc function.

It can result in unpredictable results across systems so replace it with
a function that isn't susceptible to that.

PR-URL: #6582
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis
    bnoordhuis committed May 4, 2016
    Configuration menu
    Copy the full SHA
    f6940df View commit details
    Browse the repository at this point in the history
Loading