Sitelet https://github.com/nodejs/node/commit/554cd2c27b
Skip to content

Commit 554cd2c

Browse files
addaleaxbengl
addaleax
authored and
bengl
committed
src: fix query/fragment serialization in URL::SerializeURL
These are presumably typos. PR-URL: #41759 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
1 parent 626577e commit 554cd2c

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎src/node_url.cc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1576,10 +1576,10 @@ std::string URL::Serializeurl(/sitelet?url=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fcommit%2Fconst%2520struct%2520url_data*%2520url%2C%253C%2Fdiv%253E%253C%2Fcode%253E%253C%2Fdiv%253E%253C%2Ftd%253E%253C%2Ftr%253E%253Ctr%2520class%3D%2522diff-line-row%2522%2520data-row-selected%3D%2522false%2522%253E%253Ctd%2520data-grid-cell-id%3D%2522diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7-1576-1576-0%2522%2520data-selected%3D%2522false%2522%2520role%3D%2522gridcell%2522%2520style%3D%2522background-color%3Avar%28--bgColor-default);text-align:center" tabindex="-1" valign="top" class="focusable-grid-cell diff-line-number position-relative diff-line-number-neutral left-side">1576
1576
}
15771577
}
15781578
if (url->flags & URL_FLAGS_HAS_QUERY) {
1579-
output = "?" + url->query;
1579+
output += "?" + url->query;
15801580
}
15811581
if (!exclude && url->flags & URL_FLAGS_HAS_FRAGMENT) {
1582-
output = "#" + url->fragment;
1582+
output += "#" + url->fragment;
15831583
}
15841584
return output;
15851585
}

0 commit comments

Comments
 (0)