Sitelet https://github.com/nodejs/node/commit/470f870dd0
Skip to content

Commit 470f870

Browse files
addaleaxbengl
addaleax
authored and
bengl
committed
src: reserve string allocation space early in URL::SerializeURL
This can be useful for performance when doing many string concatenations. PR-URL: #41759 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
1 parent 554cd2c commit 470f870

1 file changed

Lines changed: 19 additions & 1 deletion

File tree

‎src/node_url.cc‎

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
#include <cmath>
99
#include <cstdio>
10+
#include <numeric>
1011
#include <string>
1112
#include <vector>
1213

@@ -1545,7 +1546,23 @@ void URL::Parse(const char* input,
15451546
// https://url.spec.whatwg.org/#url-serializing
15461547
std::string URL::SerializeURL(const struct url_data* url,
15471548
bool exclude = false) {
1548-
std::string output = url->scheme;
1549+
std::string output;
1550+
output.reserve(
1551+
10 +
1552+
url->scheme.size() +
1553+
url->username.size() +
1554+
url->password.size() +
1555+
url->host.size() +
1556+
url->query.size() +
1557+
url->fragment.size() +
1558+
url->href.size() +
1559+
std::accumulate(
1560+
url->path.begin(),
1561+
url->path.end(),
1562+
0,
1563+
[](size_t sum, const auto& str) { return sum + str.size(); }));
1564+
1565+
output += url->scheme;
15491566
if (url->flags & URL_FLAGS_HAS_HOST) {
15501567
output += "//";
15511568
if (url->flags & URL_FLAGS_HAS_USERNAME ||
@@ -1581,6 +1598,7 @@ std::string URL::Serializeurl(/sitelet?url=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fcommit%2Fconst%2520struct%2520url_data*%2520url%2C%253C%2Fdiv%253E%253C%2Fcode%253E%253C%2Fdiv%253E%253C%2Ftd%253E%253C%2Ftr%253E%253Ctr%2520class%3D%2522diff-line-row%2522%2520data-row-selected%3D%2522false%2522%253E%253Ctd%2520data-grid-cell-id%3D%2522diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7-1581-1598-0%2522%2520data-selected%3D%2522false%2522%2520role%3D%2522gridcell%2522%2520style%3D%2522background-color%3Avar%28--bgColor-default);text-align:center" tabindex="-1" valign="top" class="focusable-grid-cell diff-line-number position-relative diff-line-number-neutral left-side">1581
1598
if (!exclude && url->flags & URL_FLAGS_HAS_FRAGMENT) {
15821599
output += "#" + url->fragment;
15831600
}
1601+
output.shrink_to_fit();
15841602
return output;
15851603
}
15861604

0 commit comments

Comments
 (0)