Sitelet https://github.com/nodejs/node/commit/7ebd881c29
Skip to content

Commit 7ebd881

Browse files
ofrobotsFishrock123
ofrobots
authored and
Fishrock123
committed
deps: upgrade V8 to 4.5.103.33
This brings in the patches from 4.5.103.30...4.5.103.33 fixing the issue with computed property names not working in nested literals. Full V8 4.5 commit log at: https://chromium.googlesource.com/v8/v8.git/+log/branch-heads/4.5 Fixes: #2507 PR-URL: #2870 Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: fishrock123 - Jeremiah Senkpiel <fishrock123@rocketmail.com>
1 parent 52019a1 commit 7ebd881

5 files changed

Lines changed: 61 additions & 4 deletions

File tree

‎deps/v8/build/features.gypi‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@
108108
'DebugBaseCommon': {
109109
'abstract': 1,
110110
'variables': {
111-
'v8_enable_handle_zapping%': 0,
111+
'v8_enable_handle_zapping%': 1,
112112
},
113113
'conditions': [
114114
['v8_enable_handle_zapping==1', {
@@ -118,7 +118,7 @@
118118
}, # Debug
119119
'Release': {
120120
'variables': {
121-
'v8_enable_handle_zapping%': 1,
121+
'v8_enable_handle_zapping%': 0,
122122
},
123123
'conditions': [
124124
['v8_enable_handle_zapping==1', {

‎deps/v8/codereview.settings‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
CODE_REVIEW_SERVER: https://codereview.chromium.org
2-
CC_LIST: v8-dev@googlegroups.com
2+
CC_LIST: v8-reviews@googlegroups.com
33
VIEW_VC: https://chromium.googlesource.com/v8/v8/+/
44
STATUS: http://v8-status.appspot.com/status
55
TRY_ON_UPLOAD: False

‎deps/v8/include/v8-version.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#define V8_MAJOR_VERSION 4
1212
#define V8_MINOR_VERSION 5
1313
#define V8_BUILD_NUMBER 103
14-
#define V8_PATCH_LEVEL 30
14+
#define V8_PATCH_LEVEL 33
1515

1616
// Use 1 for candidates and 0 otherwise.
1717
// (Boolean macro values are not supported by all preprocessors.)

‎deps/v8/src/ast.cc‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -441,6 +441,7 @@ void ObjectLiteral::BuildConstantProperties(Isolate* isolate) {
441441

442442
if (position == boilerplate_properties_ * 2) {
443443
DCHECK(property->is_computed_name());
444+
is_simple = false;
444445
break;
445446
}
446447
DCHECK(!property->is_computed_name());

‎deps/v8/test/mjsunit/harmony/computed-property-names.js‎

Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -300,3 +300,59 @@ function ID(x) {
300300
};
301301
}, MyError);
302302
})();
303+
304+
305+
(function TestNestedLiterals() {
306+
var array = [
307+
42,
308+
{ a: 'A',
309+
['b']: 'B',
310+
c: 'C',
311+
[ID('d')]: 'D',
312+
},
313+
43,
314+
];
315+
assertEquals(42, array[0]);
316+
assertEquals(43, array[2]);
317+
assertEquals('A', array[1].a);
318+
assertEquals('B', array[1].b);
319+
assertEquals('C', array[1].c);
320+
assertEquals('D', array[1].d);
321+
var object = {
322+
outer: 42,
323+
inner: {
324+
a: 'A',
325+
['b']: 'B',
326+
c: 'C',
327+
[ID('d')]: 'D',
328+
},
329+
outer2: 43,
330+
};
331+
assertEquals(42, object.outer);
332+
assertEquals(43, object.outer2);
333+
assertEquals('A', object.inner.a);
334+
assertEquals('B', object.inner.b);
335+
assertEquals('C', object.inner.c);
336+
assertEquals('D', object.inner.d);
337+
var object = {
338+
outer: 42,
339+
array: [
340+
43,
341+
{ a: 'A',
342+
['b']: 'B',
343+
c: 'C',
344+
[ID('d')]: 'D',
345+
},
346+
44,
347+
],
348+
outer2: 45
349+
};
350+
assertEquals(42, object.outer);
351+
assertEquals(45, object.outer2);
352+
assertEquals(43, object.array[0]);
353+
assertEquals(44, object.array[2]);
354+
assertEquals('A', object.array[1].a);
355+
assertEquals('B', object.array[1].b);
356+
assertEquals('C', object.array[1].c);
357+
assertEquals('D', object.array[1].d);
358+
})();

0 commit comments

Comments
 (0)