Sitelet https://github.com/microsoft/DirectX-Graphics-Samples/compare/master...mackrol:DirectX-Graphics-Samples:master
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/DirectX-Graphics-Samples
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: mackrol/DirectX-Graphics-Samples
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Dec 19, 2020

  1. Fixed FXC validation error: uav store write mask must match store val… 

    …ue mask, write mask is 7 and store value mask is 0.
    @mackrol
    mackrol committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    964d882 View commit details
    Browse the repository at this point in the history

  2. Hemisphere samples array is uploaded only on recreation of AO samples… 

    …. The array was previously uploaded to GPU on every frame and since the array is quite large (87031808 bytes) it caused unnecessary CPU overhead (8ms of CPU time on i7 4790K 4.4GHz 32GB RAM 2070 RTX). On simpler scenes this was main bottleneck i.e. in the default scene with grass disabled (#define RENDER_GRASS_GEOMETRY 0) framerate tripled (~100 to ~300fps) with GPU timings unaffected.

TODO:
- The array is unnecessarily triple-buffered and has to be uploaded three times on consecutive frames. Only single upload is required since the content is unchanged.
- In order to reduce size precision of the array can be reduced to half float or even 8bit SNORM.
    @mackrol
    mackrol committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    c50a1b8 View commit details
    Browse the repository at this point in the history
Loading