Sitelet https://github.com/lstrojny/functional-php/compare/value_to_key...main
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: lstrojny/functional-php
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: value_to_key
Choose a base ref
...
head repository: lstrojny/functional-php
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 31 files changed
  • 4 contributors

Commits on Mar 21, 2026

  1. PHP 8.4 migration (#257) 

    * Explicitly mark all nullable parameters

This removes the deprecations introduced in PHP 8.4

* Make iterator return types match Iterator

PHP 8.4 makes not doing so a deprecation.

* Skip tesetErrorIsThrownAsException for PHP >= 8.4

PHP 8.4 deprecates the use of E_USER_ERROR. This can mangle the exception thrown. So, skip the test
in PHP 8.4. It may be possible to fix up what's being thrown, but I haven't found anything.

Since using trigger_error for user errors is now deprecated, error_to_exception() should probably be
deprecated as well. But that's a greater decision than making sure tests work correctly.

* Fix message matching in RepeatTest::testNegativeRepeatedtimes

PHP 8.4 has changed the format of __FUNCTION__ for closures, at least.

* Force doubles to ints in group()

PHP 8.4 deprecates the implicit conversion from doubles to ints when doing so would lose precision.
However, disallowing doubles as array keys in Functional would be a BC break.

* update CI matrix and actions

* use E_USER_DEPRECATED instead of E_USER_ERROR in test

* cs fixes

* update workflows

* add test for float keys

* update test workflow

* use the right method for phpunit < 9

* cs-fixer ignore env

* use the right method for phpunit < 9

* run pcov step only for php version 7.1 which uses older version of phpunit

---------

Co-authored-by: Michael D Johnson <mjohnson@pitsco.com>
    @mattiabasone @redbeardcreator
    mattiabasone and redbeardcreator authored Mar 21, 2026
    Configuration menu
    Copy the full SHA
    c1667dc View commit details
    Browse the repository at this point in the history

  2. Fix CI: update runner from ubuntu-22.04 to ubuntu-24.04 (#260)

    @phanan
    phanan authored Mar 21, 2026
    Configuration menu
    Copy the full SHA
    3db3c5e View commit details
    Browse the repository at this point in the history

  3. Remove doctoc-generated table of contents (#261) 

    GitHub has natively supported auto-generated TOC for Markdown files
since 2021, making the manually maintained doctoc TOC redundant.
    @phanan
    phanan authored Mar 21, 2026
    Configuration menu
    Copy the full SHA
    b6e6726 View commit details
    Browse the repository at this point in the history

  4. Add frequencies function (#262) 

    Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
    @phanan @claude
    phanan and claude authored Mar 21, 2026
    Configuration menu
    Copy the full SHA
    c9d87fb View commit details
    Browse the repository at this point in the history

  5. Add juxt for applying multiple functions to the same arguments (#263)

    @phanan
    phanan authored Mar 21, 2026
    Configuration menu
    Copy the full SHA
    63aaefd View commit details
    Browse the repository at this point in the history
Loading