Flagged by CodeRabbit as Major during #3604 and #3524's AI Feedback Validation work: the ai-feedback-validation check requires AI review feedback to be tracked in FEEDBACK_RESPONSE.md with a status per item, but the file lives at a single shared repo-root path. A second PR needing a response overwrites the first PR's record - confirmed in practice on both #3604 and #3524, where the file at HEAD held a stale record from an unrelated already-merged PR (#3500) before being corrected.
Fix
Move to a per-PR path (for example FEEDBACK_RESPONSE.md generated per-PR under a scoped location, or embedded in the PR description/comment instead of a tracked file), so concurrent PRs cannot clobber each other's tracking. This changes validation behaviour for every PR using the ai-feedback-validation workflow, so needs a considered design rather than a quick patch.
Reference
Raised in #3604 and #3524's review passes; deferred there pending this dedicated issue.
Flagged by CodeRabbit as Major during #3604 and #3524's AI Feedback Validation work: the ai-feedback-validation check requires AI review feedback to be tracked in
FEEDBACK_RESPONSE.mdwith a status per item, but the file lives at a single shared repo-root path. A second PR needing a response overwrites the first PR's record - confirmed in practice on both #3604 and #3524, where the file at HEAD held a stale record from an unrelated already-merged PR (#3500) before being corrected.Fix
Move to a per-PR path (for example
FEEDBACK_RESPONSE.mdgenerated per-PR under a scoped location, or embedded in the PR description/comment instead of a tracked file), so concurrent PRs cannot clobber each other's tracking. This changes validation behaviour for every PR using the ai-feedback-validation workflow, so needs a considered design rather than a quick patch.Reference
Raised in #3604 and #3524's review passes; deferred there pending this dedicated issue.