Sitelet https://github.com/lambdaisland/deep-diff2/pull/1
Skip to content

Add support for Records - #1

Merged
plexus merged 1 commit into
lambdaisland:masterfrom
ikitommi:master
Oct 30, 2018
Merged

plexus merged 1 commit into
lambdaisland:masterfrom
ikitommi:master

Conversation

@ikitommi

@ikitommi ikitommi commented Oct 30, 2018 •

Copy link
Copy Markdown
Contributor

Records are treated as maps for simplicity.

@plexus

plexus commented Oct 30, 2018

Copy link
Copy Markdown
Member

Thanks! Does this mean records and maps with the same content are considered equal? It would be better I think to check for type+value in case of records, as that's also how equality on records is implemented.

I'll go ahead and merge this though as it's already an improvement.

@plexus
plexus merged commit 0931543 into lambdaisland:master Oct 30, 2018
@ikitommi

Copy link
Copy Markdown
Contributor Author

I agree that type+value would be better - in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants