Sitelet https://github.com/jsonapi-serializer/jsonapi-serializer/issues/140
Skip to content

Polymorphic option should be either deprecated or documented better #140

Description

@amkisko

It is not clear that polymorphic option takes priority over serializer option. Also seems that serializer option is recommended way for polymorphic relations: https://github.com/jsonapi-serializer/jsonapi-serializer#specifying-a-relationship-serializer

Code state: https://github.com/jsonapi-serializer/jsonapi-serializer/blob/master/lib/fast_jsonapi/relationship.rb#L74 and this behaviour is not documented at all.

My case: I used both polymorphic and serializer in one statement and for few hours could not realise why it does not call serializer block.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions