Sitelet https://github.com/hackmcgill/hackerAPI/issues/801
Skip to content

FR: Revamp email templates #801

Description

@pierreTklein

Each year, we have to fix bugs like sending the wrong links (discord, livesite, pdf etc.) to hackers. We also have to fix bugs where the email has the wrong confirm by / apply by dates.

This feature request is two-fold:

  • Add links to setting schema
  • Make the dates & link fields in emails parametrized, and provide the proper fields when constructing the email.

Activity

  1. brarsanmol commented on Jan 21, 2022

    @brarsanmol
    Member

    Hi Theo,

    Exactly my thoughts! Just had a conversation with @logan-r about this today. We should be passing dates, names, and social links through handlebar templates.

    Some major work has been done in the refactor to help enable this. I plan to add the social links to the settings model and allow them to modified through the dashboard. Same with the hackathon name so we don't have go through the codebase and edit all the instances of McHacks _.

  2. pierreTklein commented on Jan 21, 2022

    @pierreTklein
    MemberAuthor

    Yep. That makes sense. And then we can also load those fields automatically to the frontend instead of storing it in the constants file.

  3. linked a pull request that will close this issuefeat/refactor to typescript #775on Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions