From 36a0f4227c14f4221feb2af75d082210ce4f891a Mon Sep 17 00:00:00 2001 From: Skitals Date: Mon, 28 Nov 2022 02:18:07 -0500 Subject: [PATCH 1/4] delete tags before modifying --- share/gpodder/extensions/tagging.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/share/gpodder/extensions/tagging.py b/share/gpodder/extensions/tagging.py index bfcd6d04b..6a40d9441 100644 --- a/share/gpodder/extensions/tagging.py +++ b/share/gpodder/extensions/tagging.py @@ -93,6 +93,9 @@ def write_basic_tags(self, modify_tags, set_artist_to_album, set_version): audio.add_tags() if modify_tags: + if audio.tags is not None: + audio.delete() + if self.album is not None: audio.tags['album'] = self.album From 463f77f57a3c06f51721e910361abba97bca6333 Mon Sep 17 00:00:00 2001 From: Skitals Date: Mon, 28 Nov 2022 03:16:36 -0500 Subject: [PATCH 2/4] remove white space --- share/gpodder/extensions/tagging.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/share/gpodder/extensions/tagging.py b/share/gpodder/extensions/tagging.py index 6a40d9441..819dda514 100644 --- a/share/gpodder/extensions/tagging.py +++ b/share/gpodder/extensions/tagging.py @@ -95,7 +95,7 @@ def write_basic_tags(self, modify_tags, set_artist_to_album, set_version): if modify_tags: if audio.tags is not None: audio.delete() - + if self.album is not None: audio.tags['album'] = self.album From 4d71dd88d957ee9438c152a1f1496525dfdd9404 Mon Sep 17 00:00:00 2001 From: Skitals Date: Mon, 28 Nov 2022 15:56:34 -0500 Subject: [PATCH 3/4] add 'remove_before_modify' option adds an option to remove existing tags before writing basic tags --- share/gpodder/extensions/tagging.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/share/gpodder/extensions/tagging.py b/share/gpodder/extensions/tagging.py index 819dda514..99aff9687 100644 --- a/share/gpodder/extensions/tagging.py +++ b/share/gpodder/extensions/tagging.py @@ -62,7 +62,8 @@ 'auto_embed_coverart': False, 'set_artist_to_album': False, 'set_version': 4, - 'modify_tags': True + 'modify_tags': True, + 'remove_before_modify': False } @@ -82,7 +83,7 @@ def remove_tags(self): audio.delete() audio.save() - def write_basic_tags(self, modify_tags, set_artist_to_album, set_version): + def write_basic_tags(self, remove_before_modify, modify_tags, set_artist_to_album, set_version): audio = File(self.filename, easy=True) if audio is None: @@ -93,7 +94,7 @@ def write_basic_tags(self, modify_tags, set_artist_to_album, set_version): audio.add_tags() if modify_tags: - if audio.tags is not None: + if remove_before_modify and audio.tags is not None: audio.delete() if self.album is not None: @@ -287,7 +288,8 @@ def write_info2file(self, info, episode): if self.container.config.always_remove_tags: audio.remove_tags() else: - audio.write_basic_tags(self.container.config.modify_tags, + audio.write_basic_tags(self.container.config.remove_before_modify, + self.container.config.modify_tags, self.container.config.set_artist_to_album, self.container.config.set_version) From b35bed662d39a995f124644feed16d374111631b Mon Sep 17 00:00:00 2001 From: Skitals Date: Tue, 29 Nov 2022 15:55:51 -0500 Subject: [PATCH 4/4] add 'remove_before_modify' option --- share/gpodder/extensions/tagging.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/share/gpodder/extensions/tagging.py b/share/gpodder/extensions/tagging.py index 99aff9687..29d98dbe5 100644 --- a/share/gpodder/extensions/tagging.py +++ b/share/gpodder/extensions/tagging.py @@ -94,7 +94,7 @@ def write_basic_tags(self, remove_before_modify, modify_tags, set_artist_to_albu audio.add_tags() if modify_tags: - if remove_before_modify and audio.tags is not None: + if remove_before_modify: audio.delete() if self.album is not None: