spanner_v1/trace: trace_call span attributes are hard-coded and don't follow OpenTelemetry semantic conventions; should instead use incorrect standardized OpenTelemetry attributes

If we examine the code in here

python-spanner/google/cloud/spanner_v1/_opentelemetry_tracing.py

Lines 41 to 46 in fe20d41

    
           attributes = { 
        
               "db.type": "spanner", 
        
               "db.url": SpannerClient.DEFAULT_ENDPOINT, 
        
               "db.instance": session._database.name, 
        
               "net.host.name": SpannerClient.DEFAULT_ENDPOINT, 
        
           }

Fixes

We should import the package opentelemetry.semconv.attributes and from it we can use the following imported variables

"db.type" should be DB_SYSTEM aka "db.system" = "google.cloud.spanner"
"db.instance_name" should be DB_NAME aka "db.name"
"db.url" should use DB_CONNECTION_STRING aka "db.connection_string"
"net.host.name" should use NET_HOST_NAME

The code in question was written in 2020, long before OpenTelemetry standardized semantic conventions hence I am sending over a change pretty shortly to fix this!

fix: use standardized OpenTelemetry attributes when tracing

fix: use modernized and standardized OpenTelemetry when tracing

observability: annotate Session+SessionPool events

observability: annotate Session+SessionPool events (#1207)

Navigation Menu

Repository navigation

spanner_v1/trace: trace_call span attributes are hard-coded and don't follow OpenTelemetry semantic conventions; should instead use incorrect standardized OpenTelemetry attributes #1170

Fixes

34 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	attributes = {
	"db.type": "spanner",
	"db.url": SpannerClient.DEFAULT_ENDPOINT,
	"db.instance": session._database.name,
	"net.host.name": SpannerClient.DEFAULT_ENDPOINT,
	}

spanner_v1/trace: trace_call span attributes are hard-coded and don't follow OpenTelemetry semantic conventions; should instead use incorrect standardized OpenTelemetry attributes #1170

Description

Fixes

Activity

34 remaining items

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions