Sitelet https://github.com/googleapis/nodejs-pubsub/issues/1914
Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

Lease management settings should be consolidated in one place #1914

Closed
Closed
Lease management settings should be consolidated in one place#1914
Assignees
feywind
Labels
api: pubsubIssues related to the googleapis/nodejs-pubsub API.priority: p3Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Description

@hongalex
hongalex
opened on Apr 26, 2024

Currently, controlling min/max ack deadline is done in SubscriberOptions, but configuring the total extension (for a message's ack deadline) is in FlowControlOptions.

These are related settings and should be in the same place.

Separately, flow control options being in a the lease-manager.ts file seems strange, since lease management should only concern itself with modacks rather than flow/concurrency control.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: pubsubIssues related to the googleapis/nodejs-pubsub API.priority: p3Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions