Storage#update always removes all lifecycle rules if they are not specified

Issue with com.google.cloud.storage.Storage#update(com.google.cloud.storage.BucketInfo, com.google.cloud.storage.Storage.BucketTargetOption...)

Expected behaviour:

update only fields that are specified in BucketInfo parameter.

Actual behaviour:

along the updated fields, removes lifecycle rules if they are not specified.

Example code:

    val bucketId = "[...]"

    val client = StorageOptions.getDefaultInstance.getService
    val before = client.get(bucketId)
    println(s"Before: ${before.getLifecycleRules.size()}")

    val updateRequest = BucketInfo
      .newBuilder(bucketId)
      .setLabels(singletonMap("test", "test"))
      .build
    client.update(updateRequest)

    val after = client.get(bucketId)
    println(s"After: ${after.getLifecycleRules.size()}")

Actual output (for bucket with 1 lifecycle rule):

Before: 1
After: 0

I suspect that issue is located here:

java-storage/google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java

Lines 1841 to 1869 in accf502

    
           Set<Rule> rules = new HashSet<>(); 
        
           if (deleteRules != null) { 
        
             rules.addAll( 
        
                 transform( 
        
                     deleteRules, 
        
                     new Function<DeleteRule, Rule>() { 
        
                       @Override 
        
                       public Rule apply(DeleteRule deleteRule) { 
        
                         return deleteRule.toPb(); 
        
                       } 
        
                     })); 
        
           } 
        
           if (lifecycleRules != null) { 
        
             rules.addAll( 
        
                 transform( 
        
                     lifecycleRules, 
        
                     new Function<LifecycleRule, Rule>() { 
        
                       @Override 
        
                       public Rule apply(LifecycleRule lifecycleRule) { 
        
                         return lifecycleRule.toPb(); 
        
                       } 
        
                     })); 
        
           } 
        
           if (rules != null) { 
        
             Lifecycle lifecycle = new Lifecycle(); 
        
             lifecycle.setRule(ImmutableList.copyOf(rules)); 
        
             bucketPb.setLifecycle(lifecycle); 
        
           }

Thanks for reporting this, the fix is included in #852 and will go out in the next release.

fix: update BucketInfo translation code to properly handle lifecycle …

chore: release 1.115.0 (#834)

fix(1.113.14-sp): backport critical bug fixes (#993)

Navigation Menu

Repository navigation

Storage#update always removes all lifecycle rules if they are not specified #850

Expected behaviour:

Actual behaviour:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	Set<Rule> rules = new HashSet<>();
	if (deleteRules != null) {
	rules.addAll(
	transform(
	deleteRules,
	new Function<DeleteRule, Rule>() {
	@Override
	public Rule apply(DeleteRule deleteRule) {
	return deleteRule.toPb();
	}
	}));
	}
	if (lifecycleRules != null) {
	rules.addAll(
	transform(
	lifecycleRules,
	new Function<LifecycleRule, Rule>() {
	@Override
	public Rule apply(LifecycleRule lifecycleRule) {
	return lifecycleRule.toPb();
	}
	}));
	}

	if (rules != null) {
	Lifecycle lifecycle = new Lifecycle();
	lifecycle.setRule(ImmutableList.copyOf(rules));
	bucketPb.setLifecycle(lifecycle);
	}

Storage#update always removes all lifecycle rules if they are not specified #850

Description

Expected behaviour:

Actual behaviour:

Activity

BenWhitehead commented on May 27, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions