Sitelet https://github.com/googleapis/google-cloud-java/issues/13555
Skip to content

Librarian generate diff check failed on main branch #13555

Description

@github-actions

The librarian generate diff check failed on main branch.

To keep the main branch healthy, please consider reverting the triggering change first. Once the revert is merged, you can investigate the failure and submit a new PR with the fix.

Please check the logs: https://github.com/googleapis/google-cloud-java/actions/runs/28147668078

Activity

  1. github-actions commented on Jun 25, 2026

    @github-actions
    Author

    @googleapis/cloud-sdk-librarian-team The workflow failed. Workflow Run: https://github.com/googleapis/google-cloud-java/actions/runs/28147668078

  2. github-actions commented on Jun 25, 2026

    @github-actions
    Author
  3. github-actions commented on Jun 25, 2026

    @github-actions
    Author
  4. github-actions commented on Jun 25, 2026

    @github-actions
    Author
  5. github-actions commented on Jun 25, 2026

    @github-actions
    Author
  6. github-actions commented on Jun 25, 2026

    @github-actions
    Author
  7. github-actions commented on Jun 25, 2026

    @github-actions
    Author
  8. github-actions commented on Jun 26, 2026

    @github-actions
    Author
  9. github-actions commented on Jun 26, 2026

    @github-actions
    Author
  10. github-actions commented on Jun 26, 2026

    @github-actions
    Author
  11. github-actions commented on Jun 26, 2026

    @github-actions
    Author
  12. github-actions commented on Jun 26, 2026

    @github-actions
    Author
  13. github-actions commented on Jun 27, 2026

    @github-actions
    Author
  14. github-actions commented on Jun 29, 2026

    @github-actions
    Author
  15. github-actions commented on Jun 29, 2026

    @github-actions
    Author
  16. zhumin8 commented on Jun 29, 2026

    @zhumin8
    Contributor

    @nnicolee @lqiu96 Please address this failure at HEAD. We should keep HEAD green to allow development as usual.
    I put up the revert #13573 if that is reasonable.

    Also, I've merged #13568. Please test it out on generator changes like #13517, use manual trigger on the branch.
    cc. @blakeli0

  17. lqiu96 commented on Jun 29, 2026

    @lqiu96
    Member

    IIUC the above changes, we would manually need to trigger the workflow and that should automatically update our branch with the latest librarian code right?

    Still takes ~90 min via GH actions, but doesn't require us to manually configure librarian and the deps and all that?

    If so, just want to figure out the next steps to resolve this issue:

    1. Revert the above PR
    2. Add the PR back again
    3. Run the manual workflow?
  18. zhumin8 commented on Jun 29, 2026

    @zhumin8
    Contributor

    Yes. All above is right.
    Expect from chat discussion, you need addition change to pom.xml that is not supported yet. so maybe
    4. add dependency to existing pom.xml for via script
    5. or add feat to librarian to support updating dependency for existing pom.xml

  19. lqiu96 commented on Jun 29, 2026

    @lqiu96
    Member
    1. add dependency to existing pom.xml for via script
    2. or add feat to librarian to support updating dependency for existing pom.xml

    Sorry, can you explain these steps a bit more? We can follow the above to resolve the issues at HEAD.

    Step 4 refers to a script that adds this dep to all existing proto-* modules in the monorepo? As a one off thing IIUC?

    I'm not sure what Step 5 means

  20. zhumin8 commented on Jun 29, 2026

    @zhumin8
    Contributor

    Oh, step 4 suggests a short term path: use a temp script to add this JSpecify dep for existing modules.
    step 5 is as a feature that we can reuse in the future.
    (Basically what @JoeWang1127 suggested in chat)

  21. github-actions commented on Jun 29, 2026

    @github-actions
    Author
  22. github-actions commented on Jun 29, 2026

    @github-actions
    Author
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

🚨 criticalP0 critical issue. Requires immediate fix

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions