Sitelet https://github.com/fsprojects/Paket/issues/2109
Skip to content

BenchmarkDotNet doesn't seem to install all necessary dependencies #2109

Description

@smoothdeveloper

Description

paket.dependencies:

source https://www.nuget.org/api/v2
strategy: max
redirects: on
framework: >= net40

nuget BenchmarkDotNet = 0.10.1

in the nuspec of BenchmarkDotNet.Core (which is transitive dependency and installed), it seems to mention System.Threading.Tasks.Extensions

<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
    <metadata>
        <id>BenchmarkDotNet.Core</id>
        <version>0.10.1</version>
        <title>BenchmarkDotNet.Core</title>
        <authors>.NET Foundation and contributors</authors>
        <owners>.NET Foundation and contributors</owners>
        <licenseUrl>https://github.com/dotnet/BenchmarkDotNet/blob/master/LICENSE.md</licenseUrl>
        <projectUrl>https://github.com/dotnet/BenchmarkDotNet</projectUrl>
        <iconUrl>https://raw.githubusercontent.com/dotnet/BenchmarkDotNet/master/docs/guide/logo.png</iconUrl>
        <requireLicenseAcceptance>false</requireLicenseAcceptance>
        <description>Powerful .NET library for benchmarking</description>
        <copyright>.NET Foundation and contributors</copyright>
        <language>en-US</language>
        <tags>benchmark benchmarking performance</tags>
        <dependencies>
            <group targetFramework=".NETCoreApp1.1">
                <dependency id="Microsoft.NETCore.App" version="1.1.0" />
                <dependency id="System.Runtime.Serialization.Primitives" version="4.1.1" />
                <dependency id="Microsoft.DotNet.InternalAbstractions" version="1.0.0" />
                <dependency id="System.Xml.XPath.XmlDocument" version="4.0.1" />
            </group>
            <group targetFramework=".NETFramework4.5">
                <dependency id="System.Threading.Tasks.Extensions" version="4.0.0" />
            </group>
        </dependencies>
        <frameworkAssemblies>
            <frameworkAssembly assemblyName="System.Management" targetFramework=".NETFramework4.5" />
            <frameworkAssembly assemblyName="System.Xml" targetFramework=".NETFramework4.5" />
        </frameworkAssemblies>
    </metadata>
</package>

on install, csproj targetting .net 4.5 doesn't have the System.Threading.Tasks.Extensions assembly reference added which I think is a bug.

Minimal project for addition in integration tests: paketbenchmarkdotnet.zip

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions