Sitelet https://github.com/foundry-rs/compilers/pull/85
Skip to content
This repository was archived by the owner on Apr 20, 2026. It is now read-only.

fix: account for Solc inexplicably not formatting the message - #85

Merged
DaniPopes merged 2 commits into
mainfrom
dani/i-love-solc
Feb 22, 2024
Merged

DaniPopes merged 2 commits into
mainfrom
dani/i-love-solc

Conversation

@DaniPopes

Copy link
Copy Markdown
Member

Apparently it's not just old solc versions, some errors just are not formatted on the latest versions too.

Edit: if the file name does not end in .sol, the source locations are not formatted. Lol

@DaniPopes
DaniPopes requested a review from mattsse February 22, 2024 16:31
@DaniPopes
DaniPopes requested a review from Evalir as a code owner February 22, 2024 16:31
@DaniPopes

Copy link
Copy Markdown
Member Author

Testing with foundry-rs/foundry#7210

@DaniPopes
DaniPopes merged commit 73f065b into main Feb 22, 2024
@DaniPopes
DaniPopes deleted the dani/i-love-solc branch February 22, 2024 16:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants