This repository was archived by the owner on Apr 20, 2026. It is now read-only.
feat: migration to Alloy - #3
Merged
Merged
Conversation
Evalir
marked this pull request as ready for review
October 4, 2023 06:34
mattsse
approved these changes
Oct 4, 2023
mattsse
left a comment
Member
There was a problem hiding this comment.
cool, this was simple,
pending q re solidity test data
Contributor
Author
There was a problem hiding this comment.
Noticed alloy_json_abi::JsonAbi doesn't parse pre-0.5.x ABIs and we had these tests expecting this to be the case from ethabi. This shouldn't be an issue for foundry as ds-test is >=0.5.0 though, and we should prob just remove them00.
gakonst
approved these changes
Oct 4, 2023
gakonst
left a comment
Member
There was a problem hiding this comment.
let's cut the commented out tests and add a note about that in the readme -- lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.