Sitelet https://github.com/flutter/flutter/issues/69
Skip to content

sky.ColorFilter needs operator== #69

Description

@FlutterIssues

Issue by Hixie
Thursday Jul 16, 2015 at 22:25 GMT
Originally opened as https://github.com/flutter/engine/issues/25


From @abarth on July 15, 2015 19:7

When someone sets a sky.ColorFilter on either a ColorFilter widget or on an Image widget, we call operator== to check whether the filter has changed. If it has changed, we mark ourselves as needing paint. However, sky.ColorFilter doesn't implement operator==, which means we're just getting object identity, which means we're invalidating paint more often than necessary.

/cc @mpcomplete

Copied from original issue: domokit/mojo#324

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c: performanceRelates to speed or footprint issues (see "perf:" labels)engineflutter/engine related. See also e: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions