Using Coverlet.MTP v10.0.0-preview.3.g24d3f6899a I am unable to get Coverlet to pick up the coverlet.mtp.appsettings.json configuration file. Another user has reported similar as an aside in a different issue
What is also odd is that in my MTP test project that the coverlet.mtp.appsettings.json file does not look to get automatically picked up by my test project and simply gets ignored unless I directly pass in the args for what I would have provided in the json file.
Originally posted by @AraHaan in #1877
Looking at the code it appears that it might not be wired through properly because CoverletTestSessionHandler is never passed an IConfiguration object:
|
public static void AddCoverletCodeCoverage(this ITestApplicationBuilder builder) |
|
{ |
|
// Register the test session lifetime handler |
|
builder.TestHost.AddTestSessionLifetimeHandler(serviceProvider => |
|
new CoverletTestSessionHandler()); |
|
} |
This constructor is never invoked
|
public CoverletTestSessionHandler(IConfiguration? configuration, string testModule) |
|
{ |
|
_ = new CoverletMTPSettingsParser(); |
|
_settings = CoverletMTPSettingsParser.Parse(configuration, testModule); |
|
} |
but instead this one is:
|
public CoverletTestSessionHandler() |
|
{ |
|
_settings = new CoverletMTPSettings(); |
|
} |
If this is not a bug, how does one get the coverlet.mtp.appsettings.json file to load? There is no indication in diagnostic logs that it's trying to load despite being in the output directory .
Is there any chance you could get this to also work with the testconfig.json file supported by MTP? It'd be nice if I could reduce the number of files I need to manage
Using
Coverlet.MTP v10.0.0-preview.3.g24d3f6899aI am unable to get Coverlet to pick up thecoverlet.mtp.appsettings.jsonconfiguration file. Another user has reported similar as an aside in a different issueOriginally posted by @AraHaan in #1877
Looking at the code it appears that it might not be wired through properly because
CoverletTestSessionHandleris never passed anIConfigurationobject:coverlet/src/coverlet.MTP/Configuration/CoverletConfigurationExtensions.cs
Lines 17 to 22 in 56d22ef
This constructor is never invoked
coverlet/src/coverlet.MTP/InProcDataCollection/CoverletTestSessionHandler.cs
Lines 22 to 26 in 56d22ef
but instead this one is:
coverlet/src/coverlet.MTP/InProcDataCollection/CoverletTestSessionHandler.cs
Lines 17 to 20 in 56d22ef
If this is not a bug, how does one get the
coverlet.mtp.appsettings.jsonfile to load? There is no indication in diagnostic logs that it's trying to load despite being in the output directory .Is there any chance you could get this to also work with the
testconfig.jsonfile supported by MTP? It'd be nice if I could reduce the number of files I need to manage