Sitelet https://github.com/nyarly/sockjs-ruby/compare/master...cosm:sockjs-ruby:master
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nyarly/sockjs-ruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: cosm/sockjs-ruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 18 commits
  • 16 files changed
  • 4 contributors

Commits on Jan 15, 2013

  1. Possible fix for some issues seen when developing locally.

    * Needed a hook to call on_close so we could execute logic when a
      connection is closed from the client end.
    * Websocket close failed if we didn't pass through an integer status
      code, so added defaults to send this if not present. This behaviour is
      probably wrong for non-websocket clients
    Sam Mulube
    Sam Mulube committed Jan 15, 2013
    Configuration menu
    Copy the full SHA
    350cd87 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2013

  1. Configuration menu
    Copy the full SHA
    5230761 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a9cab21 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2013

  1. Remove override of method in Faye that is fixed upstream.

    This version breaks with IE 10
    Sam Mulube
    Sam Mulube committed Jan 24, 2013
    Configuration menu
    Copy the full SHA
    862ad5d View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2013

  1. Another hacky fix papering over a bug in SockJS.

    Faye::Websocket response objects, don't have a finish method, so
    currently if we reach the close method inside a Consumer from a
    websocket connection, the server will force exit.
    
    Figuring out why there is this discrepency would require some heavy duty
    archaeology into the codebase, but I'm not sure it's worth it just now.
    This fix just prevents us trying to call finish on an object that
    doesn't respond to it.
    Sam Mulube
    Sam Mulube committed Feb 6, 2013
    Configuration menu
    Copy the full SHA
    90b56c8 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2013

  1. We're seeing encoding errors running this library in production.

    Attempt to encode strings as valid UTF-8 before we do the gsub
    replacement into the string, as this just breaks if passed invalid
    UTF-8.
    Sam Mulube
    Sam Mulube committed Feb 25, 2013
    Configuration menu
    Copy the full SHA
    0d966b3 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2013

  1. Add Access-Control-Allow-Headers response for xhr transport

    This is what Safari uses, and it seems unable to connect to the server
    without this header in the response.
    Sam Mulube
    Sam Mulube committed Apr 11, 2013
    Configuration menu
    Copy the full SHA
    5b268cf View commit details
    Browse the repository at this point in the history

Commits on May 15, 2013

  1. Revert encoding hack, as it breaks more than it fixes.

    Sam Mulube
    Sam Mulube committed May 15, 2013
    Configuration menu
    Copy the full SHA
    89606e1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8b54f5d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f0b1b8b View commit details
    Browse the repository at this point in the history
  4. Add a travis build file.

    Sam Mulube
    Sam Mulube committed May 15, 2013
    Configuration menu
    Copy the full SHA
    0e3b099 View commit details
    Browse the repository at this point in the history
  5. dummy commit to test travis hook

    Sam Mulube
    Sam Mulube committed May 15, 2013
    Configuration menu
    Copy the full SHA
    c39ef33 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2013

  1. Merge pull request #1 from cosm/bugs

    Several major/minor bug fixes
    paulbellamy committed May 16, 2013
    Configuration menu
    Copy the full SHA
    de8e64b View commit details
    Browse the repository at this point in the history
  2. Let's not crash if passed invalid utf-8 strings.

    Sam Mulube
    Sam Mulube committed May 16, 2013
    Configuration menu
    Copy the full SHA
    2c4258a View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2 from cosm/encoding

    Let's not crash if passed invalid utf-8 strings.
    bjpirt committed May 16, 2013
    Configuration menu
    Copy the full SHA
    63c3f1c View commit details
    Browse the repository at this point in the history

Commits on May 17, 2013

  1. Bump version

    Sam Mulube
    Sam Mulube committed May 17, 2013
    Configuration menu
    Copy the full SHA
    51e5233 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2013

  1. Configuration menu
    Copy the full SHA
    cc763c1 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3 from cosm/utf_8_fix

    Let ruby determine the input encoding
    Sam Mulube
    Sam Mulube committed Jun 12, 2013
    Configuration menu
    Copy the full SHA
    9712d30 View commit details
    Browse the repository at this point in the history
Loading