-
Notifications
You must be signed in to change notification settings - Fork 5
Comparing changes
Open a pull request
base repository: nyarly/sockjs-ruby
base: master
head repository: cosm/sockjs-ruby
compare: master
- 18 commits
- 16 files changed
- 4 contributors
Commits on Jan 15, 2013
-
Possible fix for some issues seen when developing locally.
* Needed a hook to call on_close so we could execute logic when a connection is closed from the client end. * Websocket close failed if we didn't pass through an integer status code, so added defaults to send this if not present. This behaviour is probably wrong for non-websocket clients
Sam Mulube committedJan 15, 2013 Configuration menu - View commit details
-
Copy full SHA for 350cd87 - Browse repository at this point
Copy the full SHA 350cd87View commit details
Commits on Jan 22, 2013
-
Bug in sockjs url - we need to pass VERSION_STRING not just VERSION
Sam Mulube committedJan 22, 2013 Configuration menu - View commit details
-
Copy full SHA for 5230761 - Browse repository at this point
Copy the full SHA 5230761View commit details -
Add hackish accessors to allow grabbing remote ip/host from requests
Sam Mulube committedJan 22, 2013 Configuration menu - View commit details
-
Copy full SHA for a9cab21 - Browse repository at this point
Copy the full SHA a9cab21View commit details
Commits on Jan 24, 2013
-
Remove override of method in Faye that is fixed upstream.
This version breaks with IE 10
Sam Mulube committedJan 24, 2013 Configuration menu - View commit details
-
Copy full SHA for 862ad5d - Browse repository at this point
Copy the full SHA 862ad5dView commit details
Commits on Feb 6, 2013
-
Another hacky fix papering over a bug in SockJS.
Faye::Websocket response objects, don't have a finish method, so currently if we reach the close method inside a Consumer from a websocket connection, the server will force exit. Figuring out why there is this discrepency would require some heavy duty archaeology into the codebase, but I'm not sure it's worth it just now. This fix just prevents us trying to call finish on an object that doesn't respond to it.
Sam Mulube committedFeb 6, 2013 Configuration menu - View commit details
-
Copy full SHA for 90b56c8 - Browse repository at this point
Copy the full SHA 90b56c8View commit details
Commits on Feb 25, 2013
-
We're seeing encoding errors running this library in production.
Attempt to encode strings as valid UTF-8 before we do the gsub replacement into the string, as this just breaks if passed invalid UTF-8.
Sam Mulube committedFeb 25, 2013 Configuration menu - View commit details
-
Copy full SHA for 0d966b3 - Browse repository at this point
Copy the full SHA 0d966b3View commit details
Commits on Apr 11, 2013
-
Add Access-Control-Allow-Headers response for xhr transport
This is what Safari uses, and it seems unable to connect to the server without this header in the response.
Sam Mulube committedApr 11, 2013 Configuration menu - View commit details
-
Copy full SHA for 5b268cf - Browse repository at this point
Copy the full SHA 5b268cfView commit details
Commits on May 15, 2013
-
Revert encoding hack, as it breaks more than it fixes.
Sam Mulube committedMay 15, 2013 Configuration menu - View commit details
-
Copy full SHA for 89606e1 - Browse repository at this point
Copy the full SHA 89606e1View commit details -
Bump version as I'm going to pull this into our master I think.
Sam Mulube committedMay 15, 2013 Configuration menu - View commit details
-
Copy full SHA for 8b54f5d - Browse repository at this point
Copy the full SHA 8b54f5dView commit details -
Switch sockjs over to using MultiJson for Json parsing/serialization
Sam Mulube committedMay 15, 2013 Configuration menu - View commit details
-
Copy full SHA for f0b1b8b - Browse repository at this point
Copy the full SHA f0b1b8bView commit details -
Sam Mulube committedMay 15, 2013 Configuration menu - View commit details
-
Copy full SHA for 0e3b099 - Browse repository at this point
Copy the full SHA 0e3b099View commit details -
dummy commit to test travis hook
Sam Mulube committedMay 15, 2013 Configuration menu - View commit details
-
Copy full SHA for c39ef33 - Browse repository at this point
Copy the full SHA c39ef33View commit details
Commits on May 16, 2013
-
Merge pull request #1 from cosm/bugs
Several major/minor bug fixes
Configuration menu - View commit details
-
Copy full SHA for de8e64b - Browse repository at this point
Copy the full SHA de8e64bView commit details -
Let's not crash if passed invalid utf-8 strings.
Sam Mulube committedMay 16, 2013 Configuration menu - View commit details
-
Copy full SHA for 2c4258a - Browse repository at this point
Copy the full SHA 2c4258aView commit details -
Merge pull request #2 from cosm/encoding
Let's not crash if passed invalid utf-8 strings.
Configuration menu - View commit details
-
Copy full SHA for 63c3f1c - Browse repository at this point
Copy the full SHA 63c3f1cView commit details
Commits on May 17, 2013
-
Sam Mulube committedMay 17, 2013 Configuration menu - View commit details
-
Copy full SHA for 51e5233 - Browse repository at this point
Copy the full SHA 51e5233View commit details
Commits on Jun 12, 2013
-
Configuration menu - View commit details
-
Copy full SHA for cc763c1 - Browse repository at this point
Copy the full SHA cc763c1View commit details -
Merge pull request #3 from cosm/utf_8_fix
Let ruby determine the input encoding
Sam Mulube committedJun 12, 2013 Configuration menu - View commit details
-
Copy full SHA for 9712d30 - Browse repository at this point
Copy the full SHA 9712d30View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master