This repository was archived by the owner on Mar 7, 2021. It is now read-only.
Updating discoverResources function to ensure that matched href or src attributes always have a space in front of them. - #3
Merged
Conversation
…em. This resolves an issue we have with incorrect matches on embedded GoogleAnalytics code.
Member
|
Thanks! Looks good. :) |
cgiffard
added a commit
that referenced
this pull request
Jul 19, 2012
Updating discoverResources function to ensure that matched `href` or `src` attributes always have a space in front of them.
Contributor
Author
|
Great, thanks. Any idea when you are planning to perform your next release? |
Member
|
There's a few things I'm working on - a better mongodb cache mechanism and some general tidying up. Did you have anything specific you were after? |
Member
|
Or were you referring to NPM? I can push an update now. :) |
Contributor
Author
|
I was just referring to NPM. If you can push soon, that would be great. |
Member
|
That's done now. 0.0.6 should be the latest version - let me know if everything works OK for you! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... This resolves an issue we have with incorrect matches on embedded GoogleAnalytics code.
The standard GA code has something like:
This was causing request for resources that did not exist.