Sitelet https://github.com/binarymatt/pyres/issues/58
Skip to content
This repository was archived by the owner on Jun 5, 2023. It is now read-only.
This repository was archived by the owner on Jun 5, 2023. It is now read-only.

Queue names with colons (":") break things #58

Description

@follower

If I start a worker with:

pyres_worker "project-name:queue-name"

Then visit http://127.0.0.1:8080/workers/ the web interface breaks with:

Application Error

This is due to:

File "pyres-0.9.1-py2.7.egg/resweb/views.py", line 142, in workers
  host,pid,queues = str(w).split(':')
ValueError: too many values to unpack

Also, if a start another worker at the same time with:

pyres_worker "project-name:queue-name"

It breaks with:

File "pyres-0.9.1-py2.7.egg/pyres/worker.py", line 86, in startup
  self.prune_dead_workers()
File "pyres-0.9.1-py2.7.egg/pyres/worker.py", line 76, in prune_dead_workers
  host, pid, queues = worker.id.split(':')
ValueError: too many values to unpack

I would guess this happens in other places also.

It would be nice to be able to specify a queue name that includes a colon (":").

A fix in some places might be something like:

foo.split(':', 2)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions