Sitelet https://github.com/asc-community/MxEngine/pull/97
Skip to content

Refactoring of shader compilation - #97

Merged
fall2019 merged 2 commits into
masterfrom
shader_compilation_refactoring
Mar 16, 2024
Merged

fall2019 merged 2 commits into
masterfrom
shader_compilation_refactoring

Conversation

@fall2019

@fall2019 fall2019 commented Mar 15, 2024 •

Copy link
Copy Markdown
Member

Keep order of included shader files unchanged.
Put camera class and other common shader utils into one header file.

@fall2019 fall2019 added the enhancement refactoring or optimization label Mar 15, 2024
@fall2019
fall2019 requested a review from MomoDeve March 15, 2024 10:24
@fall2019 fall2019 self-assigned this Mar 15, 2024
@fall2019 fall2019 linked an issue Mar 15, 2024 that may be closed by this pull request
Comment thread src/Platform/OpenGL/Shaders/apply_ssgi_fragment.glsl

@MomoDeve MomoDeve left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move common include into fragment. Overall fine

@fall2019
fall2019 enabled auto-merge (squash) March 15, 2024 18:42
@fall2019
fall2019 requested a review from MomoDeve March 15, 2024 19:02
@fall2019
fall2019 merged commit 2ec56eb into master Mar 16, 2024
@fall2019
fall2019 deleted the shader_compilation_refactoring branch March 16, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement refactoring or optimization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactoring of shader compilation

2 participants