From aaffad0ad6ba5769139cfae045a95383beb35ca9 Mon Sep 17 00:00:00 2001 From: Dor-bl Date: Mon, 10 Jul 2023 23:03:22 +0300 Subject: [PATCH 1/3] fix: Add missing dependencies for types-python-dateutil --- .pre-commit-config.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index a99b5b317..d33175092 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -10,6 +10,7 @@ repos: - id: mypy entry: mypy appium/ test/functional pass_filenames: false + additional_dependencies: [types-python-dateutil==2.8.19.13] - repo: https://github.com/psf/black rev: 23.3.0 hooks: From dcdf08b67d24257700923c89ae2643f26af2892f Mon Sep 17 00:00:00 2001 From: Dor-bl Date: Mon, 10 Jul 2023 23:04:32 +0300 Subject: [PATCH 2/3] test: replace usage of selendroid app from 'test_install_app' in applications_tests.py --- test/functional/android/applications_tests.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/functional/android/applications_tests.py b/test/functional/android/applications_tests.py index 02ebcfc8a..6564c5349 100644 --- a/test/functional/android/applications_tests.py +++ b/test/functional/android/applications_tests.py @@ -34,11 +34,11 @@ def test_is_app_installed(self) -> None: assert not self.driver.is_app_installed('sdfsdf') assert self.driver.is_app_installed(APIDEMO_PKG_NAME) - @pytest.mark.skip('This causes the server to crash. no idea why') def test_install_app(self) -> None: - assert not self.driver.is_app_installed('io.selendroid.testapp') - self.driver.install_app(PATH(os.path.join('../..', 'apps', 'selendroid-test-app.apk'))) - assert self.driver.is_app_installed('io.selendroid.testapp') + self.driver.remove_app(APIDEMO_PKG_NAME) + assert not self.driver.is_app_installed(APIDEMO_PKG_NAME) + self.driver.install_app(PATH(os.path.join('../..', 'apps', 'ApiDemos-debug.apk.zip'))) + assert self.driver.is_app_installed(APIDEMO_PKG_NAME) def test_remove_app(self) -> None: assert self.driver.is_app_installed(APIDEMO_PKG_NAME) From 5732dbce71ef960e58a07740eb817a92f4f35605 Mon Sep 17 00:00:00 2001 From: Dor-bl Date: Tue, 11 Jul 2023 00:12:29 +0300 Subject: [PATCH 3/3] Revert "test: replace usage of selendroid app from 'test_install_app' in applications_tests.py" This reverts commit dcdf08b67d24257700923c89ae2643f26af2892f. --- test/functional/android/applications_tests.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/functional/android/applications_tests.py b/test/functional/android/applications_tests.py index 6564c5349..02ebcfc8a 100644 --- a/test/functional/android/applications_tests.py +++ b/test/functional/android/applications_tests.py @@ -34,11 +34,11 @@ def test_is_app_installed(self) -> None: assert not self.driver.is_app_installed('sdfsdf') assert self.driver.is_app_installed(APIDEMO_PKG_NAME) + @pytest.mark.skip('This causes the server to crash. no idea why') def test_install_app(self) -> None: - self.driver.remove_app(APIDEMO_PKG_NAME) - assert not self.driver.is_app_installed(APIDEMO_PKG_NAME) - self.driver.install_app(PATH(os.path.join('../..', 'apps', 'ApiDemos-debug.apk.zip'))) - assert self.driver.is_app_installed(APIDEMO_PKG_NAME) + assert not self.driver.is_app_installed('io.selendroid.testapp') + self.driver.install_app(PATH(os.path.join('../..', 'apps', 'selendroid-test-app.apk'))) + assert self.driver.is_app_installed('io.selendroid.testapp') def test_remove_app(self) -> None: assert self.driver.is_app_installed(APIDEMO_PKG_NAME)