Commit #19d8ec6 changes this line in sys/windows/consoletty.c
console.has_unicode = ((GetVersion() & 0x80000000) == 0);
to read
console.has_unicode = (IsWindows8OrGreater());
This changes the meaning of the test. GetVersion returns bit 31 set when running on Windows 95, 98 or Me. These versions of Windows do not support WriteConsoleOutputCharacterW, and also do not exhibit bug W343-3. Windows NT and its descendants should call WriteConsoleOutputCharacterW to work around that bug.
As changed, I expect that NetHack won't run at all on Windows 95 and its descendants, and that W343-3 will appear once more on Windows 7 and earlier.
The post to RGRN in which I described the bug is dated 5 November 2005, in the time of Windows XP. So the workaround is both necessary and effective for that version.
NetHack may be broken on Windows 95 for other reasons.
If support for Windows 95 is still desired, this change should be reverted. If not, the test should be removed and WriteConsoleOutputCharacterW should always be alled.
Commit #19d8ec6 changes this line in sys/windows/consoletty.c
console.has_unicode = ((GetVersion() & 0x80000000) == 0);to read
console.has_unicode = (IsWindows8OrGreater());This changes the meaning of the test.
GetVersionreturns bit 31 set when running on Windows 95, 98 or Me. These versions of Windows do not supportWriteConsoleOutputCharacterW, and also do not exhibit bug W343-3. Windows NT and its descendants should callWriteConsoleOutputCharacterWto work around that bug.As changed, I expect that NetHack won't run at all on Windows 95 and its descendants, and that W343-3 will appear once more on Windows 7 and earlier.
The post to RGRN in which I described the bug is dated 5 November 2005, in the time of Windows XP. So the workaround is both necessary and effective for that version.
NetHack may be broken on Windows 95 for other reasons.
If support for Windows 95 is still desired, this change should be reverted. If not, the test should be removed and
WriteConsoleOutputCharacterWshould always be alled.