Sitelet https://github.com/Microsoft/TypeScript/pull/30232
Skip to content

Use .tsbuildinfo to build with tsc and tsc --w when not using build mode - #30232

Merged
Sheetal Nandi (sheetalkamat) merged 7 commits into
masterfrom
incrementalWithNormalTsc
Mar 9, 2019
Merged

Sheetal Nandi (sheetalkamat) merged 7 commits into
masterfrom
incrementalWithNormalTsc

Conversation

@sheetalkamat

@sheetalkamat Sheetal Nandi (sheetalkamat) commented Mar 5, 2019 •

Copy link
Copy Markdown
Member

Works on top of #29813
This change should help with #12996

@sheetalkamat

Sheetal Nandi (sheetalkamat) commented Mar 5, 2019 •

Copy link
Copy Markdown
Member Author

Ryan Cavanaugh (@RyanCavanaugh) Ron Buckton (@rbuckton) Daniel Rosenwasser (@DanielRosenwasser) This change is on top of tsc --b generating .tsbuildinfo. The main change is that tsc --w will use the hash as file version instead of count of changes in lifetime of the span (as otherwise the written signature makes no sense in determining if the file has changed and technically we want all tsc modes to use same version type so its compatible in all modes?).
Its ready for review as well.

@sheetalkamat

Copy link
Copy Markdown
Member Author

Ryan Cavanaugh (@RyanCavanaugh) please take a look at this as well since I think having same file version when writing tsbuildinfo is important for things to work correctly and because we don't have published API for tsbuild yet many apis depend on watch api to build the projects and we should not regress there by writing conflicting file versions.

@sheetalkamat
Sheetal Nandi (sheetalkamat) changed the base branch from incrementalBuildInfo to master March 8, 2019 23:50
Comment thread src/compiler/watch.ts Outdated
@sheetalkamat
Sheetal Nandi (sheetalkamat) deleted the incrementalWithNormalTsc branch March 9, 2019 01:18
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants