This repository was archived by the owner on Jul 5, 2020. It is now read-only.
Move W3C classes to base SDK so everyone can use them - #1138
Merged
Merged
Conversation
added 2 commits
January 24, 2019 17:12
Liudmila Molkova (lmolkova)
requested review from
Dmitry-Matveev and
Cijo Thomas (cijothomas)
January 25, 2019 02:53
Dmitry-Matveev
approved these changes
Jan 25, 2019
Dmitry-Matveev
left a comment
Member
There was a problem hiding this comment.
Pls. take a look at the comment before merge.
| /// https://github.com/w3c/distributed-tracing/blob/master/trace_context/HTTP_HEADER_FORMAT.md#trace-id | ||
| /// </summary> | ||
| /// <returns>Random 16 bytes array encoded as hex string</returns> | ||
| [Obsolete("Use Microsoft.ApplicationInsights.Extensibility.W3C.W3CUtilities.GenerateTraceId instead.", true)] |
Member
There was a problem hiding this comment.
Will it break compilation? It can be fine if we didn't have this feature in any stable (I remember we didn't), so migrating between stables won't suddenly stop compiling, right?
| /// <param name="activity">Activity to generate W3C context on.</param> | ||
| /// <returns>The same Activity for chaining.</returns> | ||
| [Obsolete("Not ready for public consumption.")] | ||
| [Obsolete("Microsoft.ApplicationInsights.Extensibility.W3C.W3CActivityExtensions.GenerateW3CContext instead.", true)] |
Member
There was a problem hiding this comment.
You may need to add "Use" here and in the other cases below.
Cijo Thomas (cijothomas)
approved these changes
Jan 25, 2019
| /// https://github.com/w3c/distributed-tracing/blob/master/trace_context/HTTP_HEADER_FORMAT.md#trace-id | ||
| /// </summary> | ||
| /// <returns>Random 16 bytes array encoded as hex string</returns> | ||
| [Obsolete("Use Microsoft.ApplicationInsights.Extensibility.W3C.W3CUtilities.GenerateTraceId instead.", true)] |
Contributor
There was a problem hiding this comment.
I'd also mention the name of the nuget package as well - Microsoft.ApplicationInsights
added 4 commits
January 25, 2019 17:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
W3C implementation is used by Web and AspNetCore SDKs.
We are going to enable W3C for some 1DS users that do not necessarily use Web SDK (and reference DependencyCollector that declares W3C implementation).
Without this change, we would require everyone to install base + dependency collector just to onboard W3C. With this change, it is still an explicit choice to enable it.
W3C is moved to base, Implementation in dependency collector is deprecated with error.