Sitelet https://github.com/Microsoft/ApplicationInsights-dotnet-server/issues/780
Skip to content
This repository was archived by the owner on Jul 5, 2020. It is now read-only.
This repository was archived by the owner on Jul 5, 2020. It is now read-only.

Failed HTTP outgoing requests are not tracked on .NET Core #780

Description

Commit 38865b6

Prevents dependency to be collected when response is null. This corresponds to the valid case when an exception was thrown during request processing (because of network, dns, timeout). This case is treated specially in the code.

It is logged in internal telemetry as

AI (Internal): HttpCoreDiagnosticSourceListener OnNext failed to call event handler. Error details 'Event System.Net.Http.HttpRequestOut.Stop: cannot cast response to expected type HttpResponseMessage' 

Tests for failed/canceled requests should be verified or implemented if missing.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions