Sitelet https://github.com/Microsoft/ApplicationInsights-dotnet-server/issues/1280
Skip to content
This repository was archived by the owner on Jul 5, 2020. It is now read-only.
This repository was archived by the owner on Jul 5, 2020. It is now read-only.

EventCounters are reported under PerformanceCounter as opposed to CustomMetric #1280

Description

EventCounters are currently reported with a special property "customPerfCounter"=true, which makes back end treat it as a PerformanceCounter. This logic exists in back end to maintain backward compatibility, when PerformanceCounter type was deprecated in favor of MetricTelemetry, to ensure performance counters collected by PerformanceCounterModule continues to appear in perfcounter table.

There is no backward compatibility issue with EventCounter, and it should be reported under customMetrics, like any other regular metric.

Though we just shipped the very 1st EventCounter collection module (2.11.0), I propose to fix this in 2.11.1, before bigger customer adoption.

The docs current state EventCounters appear under PerformanceCounter, and it must be corrected as well.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions