Sitelet https://github.com/Microsoft/ApplicationInsights-dotnet-server/issues/1120
Skip to content
This repository was archived by the owner on Jul 5, 2020. It is now read-only.
This repository was archived by the owner on Jul 5, 2020. It is now read-only.

Correlation doesn't work for localhost => breaks Azure Service Fabric's built-in reverse proxy #1120

Description

@zakimaksyutov

Built-in Azure Service Fabric's reverse proxy is access through localhost. Due to this logic (line about localhost) AI SDK doesn't do correlation:

	<Add Type="Microsoft.ApplicationInsights.DependencyCollector.DependencyTrackingTelemetryModule, Microsoft.AI.DependencyCollector">
		<ExcludeComponentCorrelationHttpHeadersOnDomains>
			<!-- 
    Requests to the following hostnames will not be modified by adding correlation headers.         
    Add entries here to exclude additional hostnames.
    NOTE: this configuration will be lost upon NuGet upgrade.
    -->
			<Add>core.windows.net</Add>
			<Add>core.chinacloudapi.cn</Add>
			<Add>core.cloudapi.de</Add>
			<Add>core.usgovcloudapi.net</Add>
			<Add>localhost</Add>
			<Add>127.0.0.1</Add>
		</ExcludeComponentCorrelationHttpHeadersOnDomains>
		<IncludeDiagnosticSourceActivities>
			<Add>Microsoft.Azure.EventHubs</Add>
			<Add>Microsoft.Azure.ServiceBus</Add>
		</IncludeDiagnosticSourceActivities>
	</Add>

According to Liudmila Molkova (@lmolkova) this logic isn't required anymore. Let's remove it?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions