You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Paul Harrington (pharring)
changed the title
Put back DiagnosticSourceListener tests
Fix NRE in DiagnosticSourceListener when property values are null
Jan 15, 2018
Build - 3 error(s), 10 warning(s)
src\DiagnosticSourceListener\DiagnosticSourceListenerSubscription.cs(61):src\DiagnosticSourceListener\DiagnosticSourceListenerSubscription.cs(61,0): Error CA1305: Microsoft.Globalization : Because the behavior of 'Convert.ToString(object)' could vary based on the current user's locale settings, replace this call in 'DiagnosticSourceListenerSubscription.OnNext(KeyValuePair<string, object>)' with a call to 'Convert.ToString(object, IFormatProvider)'. If the result of 'Convert.ToString(object, IFormatProvider)' will be displayed to the user, specify System.Globalization.CultureInfo.CurrentCulture as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify System.Globalization.CultureInfo.InvariantCulture.
src\DiagnosticSourceListener\DiagnosticSourceListenerSubscription.cs(61):src\DiagnosticSourceListener\DiagnosticSourceListenerSubscription.cs(61,0): Error CA1305: Microsoft.Globalization : Because the behavior of 'Convert.ToString(object)' could vary based on the current user's locale settings, replace this call in 'DiagnosticSourceListenerSubscription.OnNext(KeyValuePair<string, object>)' with a call to 'Convert.ToString(object, IFormatProvider)'. If the result of 'Convert.ToString(object, IFormatProvider)' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'.
Process 'msbuild.exe' exited with code '1'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DiagnosticSourceListener tests project got removed with the last round of project shuffling (#135)
This puts it back.
Also fix a bug (NRE) when property values are null and add a test to cover that case.