This repository was archived by the owner on Jun 10, 2020. It is now read-only.
Remove DiagnosticAdapter and use DiagnosticListener directly - #852
Merged
Liudmila Molkova (lmolkova) merged 4 commits intoMar 23, 2019
Merged
Conversation
|
|
||
| public void OnNext(KeyValuePair<string, object> value) | ||
| { | ||
| if (value.Key == "Microsoft.AspNetCore.Hosting.HttpRequestIn.Start") |
Contributor
There was a problem hiding this comment.
This would be better as a switch instead of an if/else/../else chain.
Author
|
I think Dmitry-Matveev has proof that it indeed saves some performance and it should be merged. I believe the main reason for perf hit from DiagnosticsAdapter was in IRouteData interface - we created this to avoid taking the dependency on the Microsoft.AspNetCore.Routing.Abstractions and DiagnosticAdapter was dynamically typing IRouteData from that package to ours. |
Liudmila Molkova (lmolkova)
requested review from
Dmitry-Matveev and
Cijo Thomas (cijothomas)
March 22, 2019 17:55
Cijo Thomas (cijothomas)
approved these changes
Mar 22, 2019
Cijo Thomas (cijothomas)
left a comment
Contributor
There was a problem hiding this comment.
Liudmila Molkova (@lmolkova) Please add changelog.md as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try out using DiagnosticListener without DiagnosticAdapter and see it it improves performance